aw_mmc: Reset controller and configure read fifo size
ClosedPublic
Actions

Authored by thj on Wed, Feb 4, 10:31 AM.

Details

Reviewers

manu
adrian
andrew

Commits

rGec5d4664915f: aw_mmc: Reset card

Summary

On h616 (and I think h6, but this isn't verified) we need to reset the
controller, configure read and write and set the read fifo size to get a
working sd card.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

thj created this revision.Wed, Feb 4, 10:31 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 4, 10:31 AM

thj requested review of this revision.Wed, Feb 4, 10:31 AM

Harbormaster completed remote builds in B70392: Diff 171133.Wed, Feb 4, 10:31 AM

thj added a parent revision: D54909: aw_mmc: Add H616 mmc and emmc config.Wed, Feb 4, 10:31 AM

This looks fine to me, nice catch!

This revision is now accepted and ready to land.Wed, Feb 4, 3:18 PM

manu requested changes to this revision.Wed, Feb 4, 3:58 PM

manu added inline comments.

sys/arm/allwinner/aw_mmc.c
746	How where those delay chosen and why it's only done where there is a fifo threashold ?
752	We disable the FIFO and never use it so are you sure that it's needed ?