riscv: Add macro for hfence.gvma instruction
ClosedPublic
Actions

sys/riscv/include/atomic.h
41 ↗	(On Diff #170325)	Let's put it in riscv/include/cpufunc.h instead? atomic.h isn't really the right place for this, it's more similar to sfence_vma() etc..

Agreed. I will update the patch.

Moved hfence_gvma from atomic.h to cpufunc.h and changed it to an inline function.

Harbormaster completed remote builds in B70111: Diff 170346.Sat, Jan 24, 7:46 PM

doonbsd_gmail.com edited the summary of this revision. (Show Details)Sat, Jan 24, 7:48 PM

markj accepted this revision as: markj.Sun, Jan 25, 4:03 PM

This revision is now accepted and ready to land.Sun, Jan 25, 4:03 PM

riscv: Add an inline function hfence_gvma() for hfence.gvma instruction.

This revision now requires review to proceed.Sun, Jan 25, 4:54 PM

Harbormaster completed remote builds in B70133: Diff 170404.Sun, Jan 25, 4:54 PM

Hold on. I just found one style problem. There must be a empty line after start curly brace when the function has single line body.

I send an updated patch.

In D54857#1254516, @doonbsd_gmail.com wrote:

Hold on. I just found one style problem. There must be a empty line after start curly brace when the function has single line body.

I send an updated patch.

That style(9) rule was dropped years ago

So, this can't be merged now? Shall I drop that change and update new diff?

In D54857#1254686, @doonbsd_gmail.com wrote:

So, this can't be merged now? Shall I drop that change and update new diff?

No, it's ok as-is. Indeed, style(9) doesn't require the blank line, but most of the other wrappers in this file have one so we might as well stay consistent.

In D54857#1254906, @markj wrote:

In D54857#1254686, @doonbsd_gmail.com wrote:

So, this can't be merged now? Shall I drop that change and update new diff?

No, it's ok as-is. Indeed, style(9) doesn't require the blank line, but most of the other wrappers in this file have one so we might as well stay consistent.