vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
AcceptedPublic
Actions

Authored by michaelo on Fri, Jan 23, 8:07 PM.

Details

Reviewers

ziaee
emaste
imp

Summary

PR: 292598
Approved by: ziaee, emaste
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70082
Build 66965: arc lint + arc unit

Event Timeline

michaelo created this revision.Fri, Jan 23, 8:07 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 23, 8:07 PM

michaelo requested review of this revision.Fri, Jan 23, 8:07 PM

Harbormaster completed remote builds in B70080: Diff 170285.Fri, Jan 23, 8:07 PM

It's not so much that it's ignored, but UEFI boot does not use vga mode so the hw.vga tunables don't do anything. Maybe something like "Because UEFI boot does not use VGA mode, ..."?

ziaee added inline comments.Fri, Jan 23, 8:13 PM

share/man/man4/vt.4
204–205	I would instead do something like this

To expand on my comment - the reason I think it's worth mentioning that is to make it clear we haven't made a choice to ignore this tunable with UEFI, it's that it just doesn't apply with UEFI.

emaste added inline comments.Fri, Jan 23, 8:14 PM

share/man/man4/vt.4
204–205	Yes, that addresses my comment. Maybe "on systems that boot via legacy BIOS"?

In D54842#1253714, @emaste wrote:

To expand on my comment - the reason I think it's worth mentioning that is to make it clear we haven't made a choice to ignore this tunable with UEFI, it's that it just doesn't apply with UEFI.

ACK

Incorporate comments

Harbormaster completed remote builds in B70082: Diff 170287.Fri, Jan 23, 8:32 PM

ziaee added inline comments.Fri, Jan 23, 8:36 PM

share/man/man4/vt.4
204–205	That's fine with me, but I think that's a lot of extra words.

michaelo added inline comments.Fri, Jan 23, 8:44 PM

share/man/man4/vt.4
204–205	I used a more compact version.

ziaee accepted this revision.Fri, Jan 23, 8:57 PM

This revision is now accepted and ready to land.Fri, Jan 23, 8:57 PM

michaelo retitled this revision from vt.4: Document hw.vga.textmode is ignored in UEFI boot mode to vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.Fri, Jan 23, 9:00 PM

Many tools expect git commit titles to be 50 or less characters

imp accepted this revision.Sat, Jan 24, 1:46 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

vt.4

6 lines

Diff 170287

View Options

vt.4: Document that hw.vga.textmode does not apply for UEFI(8) bootAcceptedPublicActions