Page MenuHomeFreeBSD

ext2fs: Simplify location of entries in an HTree index
Needs ReviewPublic

Authored by jhb on Jan 20 2026, 3:59 PM.
Tags
None
Referenced Files
F146543380: D54798.id.diff
Tue, Mar 3, 12:50 PM
Unknown Object (File)
Sun, Mar 1, 1:27 PM
Unknown Object (File)
Fri, Feb 27, 12:44 PM
Unknown Object (File)
Sat, Feb 21, 1:24 PM
Unknown Object (File)
Sat, Feb 7, 11:41 PM
Unknown Object (File)
Jan 30 2026, 8:42 PM
Unknown Object (File)
Jan 24 2026, 9:15 PM
Unknown Object (File)
Jan 24 2026, 7:22 AM
Subscribers

Details

Reviewers
fsu
jrtc27
Group Reviewers
cheri
Summary

Just require a fixed size for h_info_len to permit using a simpler
assignment.

Obtained from: CheriBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70024
Build 66907: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jan 20 2026, 3:59 PM

This probably needs more of an explanation for the issue with this pattern on CHERI than we had downstream

Hmm, I guess I could talk about subobject bounds and add 'Effort: CHERI' tag to it. My reasoning was that aside from CHERI, it is just more readable for upstream.

IMO it's worth putting all of that in the commit message -- that this came from CHERI and why, but also it's just generally better.

sys/fs/ext2fs/ext2_htree.c
289

Hmmm, looking again at the Linux code in question, it doesn't check the length when mounting, but only in get_dx_countlimit() if rlen == 12.