cloud: Add GCE VM Product Name to magic string detection list
Needs ReviewPublic
Actions

Authored by wac_gmail.com on Sun, Jan 11, 10:15 AM.

Details

Reviewers

Summary

Recognize "Google Compute Engine" in smbios system information product name as an indicator of KVM-based virtualization. Working hypervisor detection is necessary on GCE in order to apply PCI_QUIRK_ENABLE_MSI_VM.

Test Plan

Tested on c4a and c4 family VMs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wac_gmail.com created this revision.Sun, Jan 11, 10:15 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jan 11, 10:15 AM

wac_gmail.com requested review of this revision.Sun, Jan 11, 10:15 AM

This is a much more GCE specific change for hypervisor detection. Works on arm64 and amd64 VM types.

emaste added a subscriber: delphij.Mon, Jan 12, 4:41 PM

markj added subscribers: jtranoleary_google.com, veethebee_google.com, shailend_google.com.Mon, Jan 12, 4:50 PM

ziaee added a subscriber: ziaee.Mon, Jan 12, 5:02 PM

And how does a "-metal" (ie: Bare metal) Google Compute Engine behave with this patch?

Currently bare metal is not supported with FreeBSD on Google Compute Engine, but there are plans to support it soon. However, this change would indeed cause future bare metal instances to be incorrectly marked as using KVM-based virtualization. From some internal investigation, it is not immediately clear if there are consistent differences between virtualized versus bare metal instances in terms of info in the SMBIOS tables.

When I get a chance I'll fire up some bare metal vms and see what I get out of dmidecode. On vacation this week so it'll be a little bit.

Revision Contents
Changeset List

Path

Size

sys/

dev/

smbios/

smbios_subr.c

1 line

Diff 169460

View Options

sys/dev/smbios/smbios_subr.c

cloud: Add GCE VM Product Name to magic string detection listNeeds ReviewPublicActions