Page MenuHomeFreeBSD

ixl: verify flowid is valid before setting rsstype & flowid
ClosedPublic

Authored by gallatin on Thu, Jan 1, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 5, 4:56 PM
Unknown Object (File)
Thu, Jan 1, 1:43 PM
Unknown Object (File)
Thu, Jan 1, 10:50 AM
Unknown Object (File)
Thu, Jan 1, 9:13 AM
Unknown Object (File)
Thu, Jan 1, 8:58 AM
Subscribers

Details

Reviewers
erj
kgalazka
kbowling
adrian
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rGac1cd655f647: ixl: verify flowid is valid before setting rsstype & flowid
Summary

According to section 8.3.2.2.1 of the XL710 datasheet,
FLTSTAT indicates if RSS hashing was used (or flow director
or nothing) to arrive at the flowid it is reporting.
We need to check this before reporting the flowid and setting the
rss type. Not checking this allows invalid flowids (0s) to be
reported for some TCP traffic (it seems to mostly impact incoming
connections). This leads to the inp flowid being 0, and egress
traffic being unbalanced (going to tx queue 0, and NIC 0 of an
lacp bundle).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable