Page MenuHomeFreeBSD
Differential D53798

exterror.9: explain buffers and bios usage of extended errors
ClosedPublic
Actions

Authored by kib on Tue, Nov 18, 4:25 AM.
Tags
None
Referenced Files
F136590934: D53798.diff
Tue, Nov 18, 12:00 PM
F136579302: D53798.id166650.diff
Tue, Nov 18, 10:54 AM
F136573969: D53798.id.diff
Tue, Nov 18, 10:14 AM
F136572308: D53798.id166650.diff
Tue, Nov 18, 10:03 AM
F136568967: D53798.diff
Tue, Nov 18, 9:34 AM
F136562158: D53798.id166653.diff
Tue, Nov 18, 8:39 AM
F136559130: D53798.id166648.diff
Tue, Nov 18, 8:15 AM
F136548132: D53798.id166648.diff
Tue, Nov 18, 6:51 AM
Subscribers
imp
pauamma_gundo.com
ziaee

Details

Reviewers
emaste
mckusick
pauamma_gundo.com
Group Reviewers
manpages
Commits
rGc0a38339fec3: exterror.9: explain buffers and bios usage of extended errors

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Tue, Nov 18, 4:25 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Nov 18, 4:25 AM
kib requested review of this revision.Tue, Nov 18, 4:25 AM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Tue, Nov 18, 4:38 AM
pauamma_gundo.com added inline comments.
share/man/man9/exterror.9
117
139–140

I don't understand what you mean by "internalize" here. Can you explain?

169

Pluralize consistently. (See line 209.)

192
207
kib marked 5 inline comments as done.Tue, Nov 18, 4:45 AM
kib added inline comments.
share/man/man9/exterror.9
139–140

curthread has the extended error info internally. The function moves (well, copies) external exterror into that internal state.

kib updated this revision to Diff 166650.Tue, Nov 18, 4:45 AM
kib marked an inline comment as done.

pauamma' fixes

pauamma_gundo.com accepted this revision.Tue, Nov 18, 4:51 AM

s/to internalize/copying/ fixable on commit.

share/man/man9/exterror.9
139
This revision is now accepted and ready to land.Tue, Nov 18, 4:51 AM
kib added inline comments.Tue, Nov 18, 4:58 AM
share/man/man9/exterror.9
139

Copying has the meaning of, well, copying of the plain set of bytes from one place into another. I do not want to allow this, which is why there is a helper function that does that. Even if internally it is indeed memcpy right now, that might change, this is why the KPI exterr_set_from() was added.

pauamma_gundo.com added inline comments.Tue, Nov 18, 5:06 AM
share/man/man9/exterror.9
139–140

Hmm. Point. On second thought, perhaps remove that whole sentence? I'm not sure what it adds to the previous one.

kib updated this revision to Diff 166652.Tue, Nov 18, 5:24 AM
kib marked 2 inline comments as done.

Remove the sentence.

This revision now requires review to proceed.Tue, Nov 18, 5:24 AM
pauamma_gundo.com accepted this revision.Tue, Nov 18, 5:33 AM
This revision is now accepted and ready to land.Tue, Nov 18, 5:33 AM
Closed by commit rGc0a38339fec3: exterror.9: explain buffers and bios usage of extended errors (authored by kib). · Explain WhyTue, Nov 18, 5:36 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGc0a38339fec3: exterror.9: explain buffers and bios usage of extended errors.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
82 lines

Diff 166653

View Options

share/man/man9/exterror.9

Loading...