Page MenuHomeFreeBSD
Differential D53578

stand: Handle dynamic gang headers
ClosedPublic
Actions

Authored by markj on Tue, Nov 4, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 1:22 PM
Unknown Object (File)
Wed, Nov 5, 12:05 PM
Unknown Object (File)
Wed, Nov 5, 11:00 AM
Unknown Object (File)
Wed, Nov 5, 9:20 AM
Unknown Object (File)
Wed, Nov 5, 4:32 AM
Unknown Object (File)
Wed, Nov 5, 2:25 AM
Unknown Object (File)
Tue, Nov 4, 9:38 PM
Unknown Object (File)
Tue, Nov 4, 9:38 PM
View All 12 Files
Subscribers
dab
delphij
imp

Details

Reviewers
manu
imp
Commits
rG4d6801a6b5bd: stand: Teach the zfs loader about dynamic gang headers
Summary

There is a pool feature, dynamic_gang_header, that is enabled by default
in new pools. When this feature is active, gang headers may be larger
than 512 bytes. The loader needs to be taught to cope with that.

Try using the vdev ashift to pick the gang block header size. If the
checksum fails, fall back to the old gang block header size.

This is based on a patch by Paul Dagnelie, with testing and a few fixups
from me.

PR: 289690

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Tue, Nov 4, 1:39 PM
Herald added a reviewer: manu. · View Herald TranscriptTue, Nov 4, 1:39 PM
Herald added subscribers: dab, delphij, imp. · View Herald Transcript
markj requested review of this revision.Tue, Nov 4, 1:39 PM
Harbormaster completed remote builds in B68406: Diff 165811.Tue, Nov 4, 1:39 PM
imp accepted this revision.Tue, Nov 4, 5:54 PM

So this looks good. Minor quibble over naming...

stand/libsa/zfs/zfsimpl.c
2346

impl? Ususally we've moved to calling these _flags() or similar. impl usually is for something else...

This revision is now accepted and ready to land.Tue, Nov 4, 5:54 PM
markj added inline comments.Tue, Nov 4, 9:30 PM
stand/libsa/zfs/zfsimpl.c
2346

That's fairly idomatic in ZFS code. There are several other examples in this file, zfs_mount_impl(), vdev_write_bootenv_impl()...

imp added inline comments.Tue, Nov 4, 9:53 PM
stand/libsa/zfs/zfsimpl.c
2346

Ok. The rest of the storage stack is different... but I'm happy if there's a consistency here

Closed by commit rG4d6801a6b5bd: stand: Teach the zfs loader about dynamic gang headers (authored by markj). · Explain WhyThu, Nov 6, 4:03 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4d6801a6b5bd: stand: Teach the zfs loader about dynamic gang headers.

Revision Contents
Changeset List

PathSize
stand/
libsa/
zfs/
67 lines
sys/
cddl/
boot/
zfs/
15 lines

Diff 165966

View Options

stand/libsa/zfs/zfsimpl.c

Loading...
View Options

sys/cddl/boot/zfs/zfsimpl.h

Loading...