ddb: improve printing of inp_flags
ClosedPublic
Actions

Authored by tuexen on Oct 31 2025, 3:06 PM.

Details

Reviewers

markj
glebius
peter.lei_ieee.org
lstewart
eri

Commits

rGca35cee7c388: ddb: improve printing of inp_flags
rG8236a5ef8910: ddb: improve printing of inp_flags
rGfee2e6b9fae2: ddb: improve printing of inp_flags

Summary

Add four missing flags (INP_BINDANY, INP_INHASHLIST, INP_RESERVED_0, INP_BOUNDFIB) used in inp_flags and remove one flag (INP_ORIGDSTADDR), which is actually a flag used in inp_flags2 and not in inp_flags.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Oct 31 2025, 3:06 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptOct 31 2025, 3:06 PM

tuexen requested review of this revision.Oct 31 2025, 3:06 PM

This code should really use %b, as documented in printf(9).

remove one flag (INP_ORIGDSTADDR), which is actually a flag used in inp_flags2 and not in inp_flags.

Don't we want to print inp_flags2 as well? BTW, it seems very easy to use the wrong flag field. It should at least be called INP2_ORIGDSTADDR or something like that.

This revision is now accepted and ready to land.Oct 31 2025, 4:43 PM

In D53498#1221542, @markj wrote:

This code should really use %b, as documented in printf(9).

I agree. But we have this kind of code in more than one place. I can take a look.

remove one flag (INP_ORIGDSTADDR), which is actually a flag used in inp_flags2 and not in inp_flags.

Don't we want to print inp_flags2 as well? BTW, it seems very easy to use the wrong flag field. It should at least be called INP2_ORIGDSTADDR or something like that.

Yes, we want to print inp_flags2, too. This will be a separate change. And I agree with your proposed name change. There is something like INP_2PCP_SET, but I would prefer something like INP2_PCP_SET or INP_2_PCP_SET. Any preference?

Closed by commit rGfee2e6b9fae2: ddb: improve printing of inp_flags (authored by tuexen). · Explain WhyOct 31 2025, 6:01 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGfee2e6b9fae2: ddb: improve printing of inp_flags.

In D53498#1221585, @tuexen wrote:

In D53498#1221542, @markj wrote:

This code should really use %b, as documented in printf(9).

I agree. But we have this kind of code in more than one place. I can take a look.

Have a look at D53507 and D53510 which does this in the networking related files.

remove one flag (INP_ORIGDSTADDR), which is actually a flag used in inp_flags2 and not in inp_flags.

Don't we want to print inp_flags2 as well? BTW, it seems very easy to use the wrong flag field. It should at least be called INP2_ORIGDSTADDR or something like that.

Yes, we want to print inp_flags2, too. This will be a separate change. And I agree with your proposed name change. There is something like INP_2PCP_SET, but I would prefer something like INP2_PCP_SET or INP_2_PCP_SET. Any preference?