tcp: improve credential handling in syncache
ClosedPublic
Actions

Authored by tuexen on Oct 27 2025, 6:01 PM.

Details

Reviewers

markj
glebius
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rG4b555b56edfd: tcp: improve credential handling in syncache
rG71f94c1e2c8f: tcp: improve credential handling in syncache
rG9611bf2fed71: tcp: improve credential handling in syncache
rG44cb1e857f04: tcp: improve credential handling in syncache

Summary

When adding a syncache entry, take a reference count of the credentials while the inp is still locked.
This fixes an issue introduced in D46793.
Thanks to markj@ to providing a hint to the root cause and to David Marker for reporting the issue.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Oct 27 2025, 6:01 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 27 2025, 6:01 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Oct 27 2025, 6:01 PM

glebius accepted this revision.Oct 27 2025, 6:41 PM

dave_freedave.net added a subscriber: dave_freedave.net.Oct 27 2025, 7:17 PM

tuexen accepted this revision as: transport.Oct 27 2025, 10:31 PM

This revision is now accepted and ready to land.Oct 27 2025, 10:31 PM

Closed by commit rG44cb1e857f04: tcp: improve credential handling in syncache (authored by tuexen). · Explain WhyOct 27 2025, 10:37 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG44cb1e857f04: tcp: improve credential handling in syncache.

tuexen added a commit: rG9611bf2fed71: tcp: improve credential handling in syncache.Oct 29 2025, 9:13 AM

cperciva added a commit: rG71f94c1e2c8f: tcp: improve credential handling in syncache.Oct 30 2025, 4:23 AM

tuexen added a commit: rG4b555b56edfd: tcp: improve credential handling in syncache.Oct 31 2025, 7:16 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

14 lines

Diff 165171

View Options

sys/netinet/tcp_syncache.c

tcp: improve credential handling in syncacheClosedPublicActions