vchiq: fix another logging format string for 32/64 bit

[adrian]

Summary

This is from work from https://reviews.freebsd.org/D37878.

Submitted by: Marco Devesas Campos <[e-mail]>

[adrian]

(sigh how'd I convince it that /i/ approved it)

[emaste]

sys/arm/broadcom/bcm2835/bcm2835_audio.c

264

[adrian]

sys/arm/broadcom/bcm2835/bcm2835_audio.c

264

oh h0 h0 i will have a lot of lines to fix first. :-) I went and added spaces everywhere!

[adrian]

Break out some more of the debug changes into this file

[emaste]

One question but otherwise looks OK

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c

208

(size_t) cast on g_slot_phys also?

[adrian]

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c

208

i'll check but i don't think the upstream patch that this is based on changes this!

[adrian]

rebase

[markmi_dsl-only.net]

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c

549

The armv7 builds have been broken since thus was submitted:

Building /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o
--- vchiq_2835_arm.o ---
/usr/src/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c:549:71: error: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Werror,-Wformat]
 549 |                 "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist, actual, pagelist->length, bi->buf);
     |                                           ~~                                        ^~~~~~~~~~~~~~~~
     |                                           %lu
/usr/src/sys/contrib/vchiq/interface/vchiq_arm/vchiq_core.h:73:39: note: expanded from macro 'vchiq_log_trace'
  73 |                 printf(VCHIQ_LOG_PREFIX fmt "\n", ##__VA_ARGS__); } while (0)
     |                                         ~~~         ^~~~~~~~~~~
1 error generated.
*** [vchiq_2835_arm.o] Error code 1

[adrian]

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c

549

The armv7 builds have been broken since thus was submitted:

Building /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o
--- vchiq_2835_arm.o ---
/usr/src/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c:549:71: error: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Werror,-Wformat]
 549 |                 "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist, actual, pagelist->length, bi->buf);
     |                                           ~~                                        ^~~~~~~~~~~~~~~~
     |                                           %lu
/usr/src/sys/contrib/vchiq/interface/vchiq_arm/vchiq_core.h:73:39: note: expanded from macro 'vchiq_log_trace'
  73 |                 printf(VCHIQ_LOG_PREFIX fmt "\n", ##__VA_ARGS__); } while (0)
     |                                         ~~~         ^~~~~~~~~~~
1 error generated.
*** [vchiq_2835_arm.o] Error code 1

Can you please share how you're building it? I tried it locally and it passes each time for me;

#!/bin/sh

OBJ_BASE="/home/adrian/work/freebsd/head/freebsd-obj-arm"
SRC_BASE="/home/adrian/work/freebsd/head/freebsd-src-arm"
PORTS_BASE="/home/adrian/work/freebsd/head/freebsd-ports-arm"
MAKE_FLAGS="-j8 -s"
X_TARGET_ARCH="armv7"
KERN_CONFIG="GENERIC"
BUILD_FLAGS="NO_CLEAN=1"

env MAKEOBJDIRPREFIX="${OBJ_BASE}" make ${MAKE_FLAGS} buildkernel KERNCONF=${KERN_CONFIG} ${BUILD_FLAGS} TARGET_ARCH=${X_TARGET_ARCH}

[markmi_dsl-only.net]

See also:

https://ci.freebsd.org/job/FreeBSD-main-armv7-build/26157/

https://lists.freebsd.org/archives/dev-commits-src-main/2025-October/037175.html

[markmi_dsl-only.net]

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c

549

The official Continuous Integration builds fail with what I reported. https://ci.freebsd.org/job/FreeBSD-main-armv7-build/26157/

There are multiple reports on the lists as well.