Page MenuHomeFreeBSD
Differential D53371

vchiq: logging/tracing refactoring
ClosedPublic
Actions

Authored by adrian on Sun, Oct 26, 11:20 PM.
Tags
None
Referenced Files
F134772385: D53371.diff
Tue, Nov 4, 1:11 PM
Unknown Object (File)
Fri, Oct 31, 6:08 AM
Unknown Object (File)
Fri, Oct 31, 5:52 AM
Unknown Object (File)
Fri, Oct 31, 1:29 AM
Unknown Object (File)
Fri, Oct 31, 12:49 AM
Unknown Object (File)
Fri, Oct 31, 12:49 AM
Unknown Object (File)
Fri, Oct 31, 12:49 AM
Unknown Object (File)
Thu, Oct 30, 11:53 PM
View All 21 Files
Subscribers
imp

Details

Reviewers
andrew
emaste
Group Reviewers
ARM
Commits
rGdf764dd133ec: vchiq: logging/tracing refactoring
Summary
  • Create macros for error, info, warn, trace / debug
  • Migrate existing printf() logging to use the above macros
  • Add a sysctl knob to control it at runtime

This is based on work done in https://reviews.freebsd.org/D37878 .

Submitted by: Marco Devesas Campos <devesas.campos@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Sun, Oct 26, 11:20 PM
Herald added a reviewer: andrew. · View Herald TranscriptSun, Oct 26, 11:20 PM
Herald added a subscriber: imp. · View Herald Transcript
adrian requested review of this revision.Sun, Oct 26, 11:20 PM
Harbormaster completed remote builds in B68131: Diff 165089.Sun, Oct 26, 11:20 PM
adrian added a parent revision: D36431: vchiq: update printf-s to more architecture-independent format specifiers.Sun, Oct 26, 11:23 PM
adrian added a child revision: D53372: vchiq: fix another logging format string for 32/64 bit.
adrian added reviewers: emaste, ARM.Sun, Oct 26, 11:29 PM
emaste added a comment.Tue, Oct 28, 2:43 PM

Submitted by: Marco Devesas Campos <devesas.campos@gmail.com>

Use `--author="Marco Devesas Campos <devesas.campos@gmail.com>" to record the author info in the commit

sys/arm/broadcom/bcm2835/bcm2835_audio.c
150

What output is this referring to?

adrian added inline comments.Tue, Oct 28, 2:44 PM
sys/arm/broadcom/bcm2835/bcm2835_audio.c
150

the kernel console/output log!

adrian updated this revision to Diff 165320.Wed, Oct 29, 2:31 PM

rename macros, cleanup

Harbormaster completed remote builds in B68220: Diff 165320.Wed, Oct 29, 2:31 PM
adrian marked an inline comment as done.Wed, Oct 29, 2:39 PM
emaste accepted this revision.Wed, Oct 29, 4:06 PM

OK. I didn't check if every LOG/WARN/ERROR is the "right" severity but that's trivial to change later.

sys/arm/broadcom/bcm2835/bcm2835_audio.c
873

maybe include (0-3)?

This revision is now accepted and ready to land.Wed, Oct 29, 4:06 PM
Closed by commit rGdf764dd133ec: vchiq: logging/tracing refactoring (authored by devesas.campos_gmail.com, committed by adrian). · Explain WhyThu, Oct 30, 12:49 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGdf764dd133ec: vchiq: logging/tracing refactoring.

Revision Contents
Changeset List

PathSize
sys/
arm/
broadcom/
bcm2835/
66 lines

Diff 165367

View Options

sys/arm/broadcom/bcm2835/bcm2835_audio.c

Loading...