quot: Add tests
ClosedPublic
Actions

Authored by des on Oct 16 2025, 10:33 AM.

Details

Reviewers

markj

Commits

rG1825be32d073: quot: Add tests
rGb5f3f1a661ab: quot: Add tests
rGaa870a1935bc: quot: Add tests

Summary

To facilitate the task, we change the comparison function so that users
with equal filesystem usage are sorted by UID, and add an undocumented
option that prevents quot from replacing numerical UIDs with names. We
also switch from getfsfile(3) to getmntpoint(3) so the first line is
identical regardless of whether we pass quot a mountpoint or a device.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Oct 16 2025, 10:33 AM

Herald added subscribers: ivy, imp. · View Herald TranscriptOct 16 2025, 10:33 AM

des requested review of this revision.Oct 16 2025, 10:33 AM

Harbormaster completed remote builds in B67819: Diff 164284.Oct 16 2025, 10:33 AM

des added a parent revision: D53132: quot: Drop the -h option.Oct 16 2025, 10:33 AM

emaste added a subscriber: emaste.Oct 16 2025, 6:30 PM

emaste added inline comments.

usr.sbin/quot/tests/quot_test.sh
51–53	Does three `sync`s provide any guarantee that one or two does not?

markj added a subscriber: markj.Thu, Oct 16, 9:18 PM

markj added inline comments.

usr.sbin/quot/tests/quot_test.sh
51–53	I don't think so, `sync` is asynchronous. More reliable would be to unmount the filesystem, or update the mount to make it read-only.

des added inline comments.Thu, Oct 16, 9:24 PM

usr.sbin/quot/tests/quot_test.sh
51–53	Empirically, a single sync was not enough for the test to succeed. It is possible that a single sync plus a brief sleep would have done the trick, but I find the traditional triple sync more poetic.