Paths

Table of Contentst

Differential D53112

arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Wed, Oct 15, 12:35 PM.

Tags

None

Referenced Files

	F132610547: D53112.id164300.diff
	Sat, Oct 18, 10:01 AM

	F132593438: D53112.id164290.diff
	Sat, Oct 18, 6:25 AM

	F132539624: D53112.id164217.diff
	Fri, Oct 17, 7:35 PM

	F132539623: D53112.id.diff
	Fri, Oct 17, 7:35 PM

	F132539621: D53112.id164300.diff
	Fri, Oct 17, 7:35 PM

	Unknown Object (File)
	Fri, Oct 17, 10:37 AM

	Unknown Object (File)
	Fri, Oct 17, 6:40 AM

	Unknown Object (File)
	Fri, Oct 17, 4:40 AM

View All 15 Files

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Commits

rGd970d0246fdd: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework

Summary

Port the BP hardening and SSBD workaround from cpu_quirks to the
CPU_FEAT framework.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Wed, Oct 15, 12:35 PM

Herald added a reviewer: andrew. · View Herald TranscriptWed, Oct 15, 12:35 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Wed, Oct 15, 12:35 PM

Harbormaster completed remote builds in B67798: Diff 164217.Wed, Oct 15, 12:35 PM

The best names I can come up with for a workaround for a missing feature is feat_foo_missing or feat_foo_workaround

sys/arm64/arm64/spec_workaround.c
6	Extra line
33	Missing line
113	I'd like to keep `feat_*` for architectural features. The closest feature is `FEAT_CSV2`, however this tells us when the workaround is not needed, so maybe we could come up with something based on that. The name is used in the `hw.feat` sysctls & can be used to enable/disable features/workarounds on boot.
165	The appropriate feature here is `FEAT_SSBS`

Address review comments

Harbormaster completed remote builds in B67823: Diff 164290.Thu, Oct 16, 2:22 PM

andrew accepted this revision.Thu, Oct 16, 2:52 PM

This revision is now accepted and ready to land.Thu, Oct 16, 2:52 PM

Closed by commit rGd970d0246fdd: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyThu, Oct 16, 4:14 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGd970d0246fdd: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

96 lines

spec_workaround.c

166 lines

conf/

1 line

Diff 164300

sys/arm64/arm64/cpu_errata.c

Loading...

sys/arm64/arm64/spec_workaround.c

Loading...

sys/conf/files.arm64

Loading...