Paths

Table of Contentst

Differential D53086

fusefs: draft kernel-based implementation of auto_unmount
Needs ReviewPublic
Actions

Authored by arrowd on Tue, Oct 14, 4:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 8, 5:17 PM

	Unknown Object (File)
	Sat, Nov 8, 2:40 AM

	Unknown Object (File)
	Thu, Oct 30, 6:45 AM

	Unknown Object (File)
	Wed, Oct 29, 7:30 AM

	Unknown Object (File)
	Tue, Oct 28, 2:03 AM

	Unknown Object (File)
	Mon, Oct 27, 2:23 AM

	Unknown Object (File)
	Sun, Oct 26, 10:40 PM

	Unknown Object (File)
	Sun, Oct 26, 1:10 AM

View All 23 Files

Subscribers

Details

Reviewers

Summary

As it was suggested in D51549 here goes an attempt to implement the
auto_unmount feature from within the kernel. Currently it doesn't work at all:

The filesystem gets mounted without MNT_NOCOVER, despite specifying this flag in fuse_vfsop_mount.
Terminating the FUSE daemon results in a visible hangup during the VFS_UNMOUNT call for dozens of seconds. After some time the call returns 0 and the daemon process terminates, but the filesystem is not unmounted.
Unmounting it manually with the umount command causes this panic: https://github.com/freebsd/freebsd-src/blob/d1bd541b385d49d2ae3a8bad9df72779b606e208/sys/fs/fuse/fuse_vfsops.c#L494

Corresponding libfuse changes are there: https://github.com/libfuse/libfuse/compare/master...arrowd:libfuse:kernel-bsd-auto-unmount

@asomers Could you please provide me guidance on how to proceed?

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68117
Build 65000: arc lint + arc unit

Event Timeline

arrowd created this revision.Tue, Oct 14, 4:27 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 14, 4:27 PM

arrowd requested review of this revision.Tue, Oct 14, 4:27 PM

Harbormaster completed remote builds in B67769: Diff 164154.Tue, Oct 14, 4:27 PM

arrowd edited the summary of this revision. (Show Details)Tue, Oct 14, 4:30 PM

Fix hang by marking fdata dead

Harbormaster completed remote builds in B68117: Diff 165029.Sat, Oct 25, 6:58 PM

I have fixed the hang, but the filesystem still does not get unmounted.

Revision Contents
Changeset List

Path

Size

sbin/

mount_fusefs/

2 lines

sys/

fs/

fuse/

30 lines

3 lines

4 lines

Diff 165029

sbin/mount_fusefs/mount_fusefs.c

Loading...

sys/fs/fuse/fuse_device.c

Loading...

sys/fs/fuse/fuse_ipc.h

Loading...

sys/fs/fuse/fuse_vfsops.c

Loading...