jemalloc: Fix activating debug on WITHOUT_MALLOC_PRODUCTION

[olce]

Summary

When stable/14 was branched, MALLOC_PRODUCTION wasn't moved from
DEFAULT_NO_OPTIONS to DEFAULT_YES_OPTIONS but instead
'jemalloc_FreeBSD.h' was changed to stop defining JEMALLOC_DEBUG (and
also, strangely, to start defining MALLOC_PRODUCTION always, although
that does not have any effect in jemalloc's code).

While this effectively turned off jemalloc debugging, it also prevents
people from turning it on again. Additionally, leaving
MALLOC_PRODUCTION in __DEFAULT_NO_OPTIONS would be confusing.
Finally, this puts stable/14 in line with what was done for stable/15.

This is a direct commit to stable/14.

Fixes: 29a16ce065db ("release: update stable/14 following branching from main")
Sponsored by: The FreeBSD Foundation

[markj]

When stable/14 was branched, MALLOC_PRODUCTION wasn't moved from
DEFAULT_NO_OPTIONS to DEFAULT_YES_OPTIONS but instead
'jemalloc_FreeBSD.h' was changed to stop defining JEMALLOC_DEBUG (and
also, strangely, to start defining MALLOC_PRODUCTION always, although
that does not have any effect in jemalloc's code).

lib/libc/stdlib/malloc/jemalloc/Makefile.inc still does this (defining MALLOC_PRODUCTION). I gather that that was the old name for the debug flag. I guess that should be removed too?

[olce]

In D52850#1208187, @markj wrote:

I guess that should be removed too?

No, this one must not without further changes. It's actually because the Makefile you mention defines MALLOC_PRODUCTION (on MK_MALLOC_PRODUCTION not begin no, or MALLOC_PRODUCTION being defined as an env or make var) that the code in jemalloc_FreeBSD.h can actually avoid defining JEMALLOC_DEBUG.

[markj]

In D52850#1208194, @olce wrote:

In D52850#1208187, @markj wrote:

I guess that should be removed too?

No, this one must not without further changes. It's actually because the Makefile you mention defines MALLOC_PRODUCTION (on MK_MALLOC_PRODUCTION not begin no, or MALLOC_PRODUCTION being defined as an env or make var) that the code in jemalloc_FreeBSD.h can actually avoid defining JEMALLOC_DEBUG.

Oops, yes, I see.