Page MenuHomeFreeBSD

vtnet: deprecate loader tunable fixup_needs_csum
ClosedPublic

Authored by timo.voelker_fh-muenster.de on Sep 15 2025, 10:05 AM.
Tags
None
Referenced Files
F146488508: D52546.id162143.diff
Tue, Mar 3, 2:36 AM
F146448174: D52546.id162143.diff
Mon, Mar 2, 6:48 PM
F146444429: D52546.id.diff
Mon, Mar 2, 6:09 PM
F146438054: D52546.id162052.diff
Mon, Mar 2, 4:52 PM
F146437926: D52546.id162211.diff
Mon, Mar 2, 4:51 PM
F146437915: D52546.id162143.diff
Mon, Mar 2, 4:50 PM
F146424525: D52546.diff
Mon, Mar 2, 2:27 PM
F146413673: D52546.id162211.diff
Mon, Mar 2, 12:14 PM
Subscribers

Details

Summary

Deprecate loader tunable fixup_needs_csum of the vtnet interface.

If this tunable is enabled and vtnet receives a packet with VIRTIO_NET_HDR_F_NEEDS_CSUM set, vtnet computes the TCP/UDP checksum and writes it in the checksum field. This was somewhat useful in the time when vtnet pretended that such a packet has a correct checksum and set the mbuf flag CSUM_DATA_VALID. However, since D51686, this is not the case anymore.

Furthermore, the guest can avoid receiving packets with an incorrect checksum and VIRTIO_NET_HDR_F_NEEDS_CSUM set by disabling the feature VIRTIO_NET_F_GUEST_CSUM. With vtnet, this is possible by disabling RXCSUM on the interface.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

share/man/man4/vtnet.4
87

I guess you want something like

This tunable is deprecated and will be removed in
.Fx 16 .
timo.voelker_fh-muenster.de added inline comments.
share/man/man4/vtnet.4
87

Yes, that's probably better. Thanks!

This revision is now accepted and ready to land.Sep 16 2025, 9:37 PM