Some tests expect transmit checksum offloading to be turned of when using epair interfaces. Make this explicit which avoids breaking the tests when epair supports transmit checksum offloading.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
tests/sys/common/vnet.subr | ||
---|---|---|
45 | The comment is probably fine, but I wanted my understanding to be explicitly written down somewhere: It's not so much that the tests don't expect checksum offloading, but that they don't expect that to mean that received packets have an incorrect/unset checksum. Most users won't actually care about the checksum (because packet corruption for packets that never leave system memory is vanishingly unlikely). It might be interesting to mention this somewhere in the if_epair man page. | |
46 | Perhaps # Disable checksum offloading because if_epair never computes checksums, it just marks packets as not needing checksum verification. Some test cases want to verify the checksum. would actually be clearer. |
tests/sys/common/vnet.subr | ||
---|---|---|
45 |
Correct.
Correct.
Will add a sentence.
| |
46 | I will use # When transmit checksum offloading is enabled, if_epair does not # compute checksums, it just marks packets that this computation still # needs to be done. However, some test cases verify the checksum. # Therefore disable this for IPv4 and IPv6. while (in my view) improves your text. |