bhyve: insert VM name to the VNC screen title

[naito.yuichiro_gmail.com]

Summary

I often use Screen Sharing on macOS for the bhyve VNC console. While I'm opening multiple screens for each VM, I hardly select the correct screen that I want to see. Because all the screen names are "bhyve". I would like to insert the VM name as the screen title.

Test Plan

The VM name is shown at the VNC screen title like "bhyve:<vm name>". (<vm name> should be replaced with your VM name.)

[markj]

usr.sbin/bhyve/rfb.c

280

Rather than allocating the string here each time one connects and trying to handle allocation failure, IMO it'd be better to allocate the string once in rfb_init(), and just keep a pointer in struct rfb_softc. If the allocation fails, handle it in rfb_init() like we do with other errors.

[naito.yuichiro_gmail.com]

usr.sbin/bhyve/rfb.c

280

OK. It's a nice idea. I'll move asprintf() allocation to rfb_init().

[naito.yuichiro_gmail.com]

I moved the screen name initialization into the rfb_init() function and hold the title name on the rfb_softc.
I added an argument of rfb_softc to the rfb_send_server_init_msg() function to pass the title name.
To be consistent with the other *_msg() function, rfb_send_server_init_msg() should have 2 arguments, rfb_softc and the cfd socket.

[michaelo]

Nice idea, hopefully this will be backported.

[markj]

Looks ok to me. IMO it is unnecessary to store the string length in the softc, but it's ok.

[michaelo]

@markj , would you mind to backport it as well? Very useful!

[markj]

In D52329#1195478, @michaelo wrote:

@markj , would you mind to backport it as well? Very useful!

Yes, that's what "MFC after" in the commit log message refers to.

[michaelo]

In D52329#1195479, @markj wrote:

In D52329#1195478, @michaelo wrote:

@markj , would you mind to backport it as well? Very useful!

Yes, that's what "MFC after" in the commit log message refers to.

My bad, it wasn't present in the initial summary. Looking forward to this change.