Page MenuHomeFreeBSD

if_ovpn tests: skip float and linklocal test on < 2.7
ClosedPublic

Authored by kp on Aug 29 2025, 9:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:08 AM
Unknown Object (File)
Fri, Oct 10, 5:46 PM
Unknown Object (File)
Fri, Oct 10, 5:46 PM
Unknown Object (File)
Fri, Oct 10, 5:46 PM
Unknown Object (File)
Fri, Oct 10, 12:44 PM
Unknown Object (File)
Thu, Oct 2, 6:53 AM
Unknown Object (File)
Sun, Sep 28, 1:16 AM
Unknown Object (File)
Sun, Sep 21, 1:04 PM

Details

Summary

Earlier versions (than 2.7.0) do not support float notifications or link-local
addresses. Skip the relevant tests there.

PR: 289150
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 29 2025, 9:42 AM

Instead of skipping these and keeping around lots of code to check the ovpn version, why not just temporarily xfail them like I've done in the attached patch of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289150? That way, once Ports contains ovpn>=2.7, these tests will automatically start failing again with the message "failed: expected failure, but none found". We can remove the xfails promptly afterwards.

Instead of skipping these and keeping around lots of code to check the ovpn version, why not just temporarily xfail them like I've done in the attached patch of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289150? That way, once Ports contains ovpn>=2.7, these tests will automatically start failing again with the message "failed: expected failure, but none found". We can remove the xfails promptly afterwards.

Because temporary changes have a way of becoming permanent, and this way we only have to change things once rather than twice. And it's entirely possible that we'll have similar issues in the future.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2025, 10:10 AM
This revision was automatically updated to reflect the committed changes.