Page MenuHomeFreeBSD

release: Stop suppressing errors from VM image creation scripts
AbandonedPublic

Authored by markj on Aug 12 2025, 8:38 PM.
Tags
None
Referenced Files
F133532970: D51882.id160266.diff
Sun, Oct 26, 11:31 AM
F133454182: D51882.diff
Sat, Oct 25, 10:13 PM
Unknown Object (File)
Sat, Oct 18, 1:55 AM
Unknown Object (File)
Thu, Oct 16, 7:09 PM
Unknown Object (File)
Tue, Oct 14, 2:48 AM
Unknown Object (File)
Tue, Oct 14, 2:09 AM
Unknown Object (File)
Tue, Oct 14, 2:09 AM
Unknown Object (File)
Mon, Oct 13, 12:38 PM

Details

Reviewers
emaste
Group Reviewers
releng
Summary

In the spirit of commit 611c1457ff32 ("release: Add set -e to abort upon failure")
we should avoid this kind of blanket error suppression.

Note, there are still some uses of this pattern, e.g., in the main
release Makefile when it installs packages. In those cases it is less
clear to me whether the pattern should be removed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66205
Build 63088: arc lint + arc unit

Event Timeline

markj requested review of this revision.Aug 12 2025, 8:38 PM

If we don't have this, cloudware image failing to build results in the entire weekly snapshot dying. I don't want to not have a weekly snapshot just because the Azure port is broken.

Maybe make it optional and can be set in the config so we have "develop" and "release" modes?

If we don't have this, cloudware image failing to build results in the entire weekly snapshot dying. I don't want to not have a weekly snapshot just because the Azure port is broken.

Sorry, I should have looked more closely at the git blame output.

Sorry, I should have looked more closely at the git blame output.

No worries! Thanks for asking for review first. :-)

Maybe make it optional and can be set in the config so we have "develop" and "release" modes?

I do like this idea, though as a make -DFOO, that the snapshot builds can opt into. Unconditionally and silently squashing errors in creating some of the images isn't great practice.