Details
Details
- Reviewers
lwhsu markj - Commits
- rGab43dbe0187e: kern: fix incorrect format in device_if.m
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The tabbed indentation is correct. If anything, the other methods should be converted to use the correct style.
(Long long ago, subr_bus.c was indented using 4 spaces. That was fixed in commit 38c490a10f71c784fdbf2b8d663a83b78c23ced4, but this file was not updated.)
Comment Actions
Approved
You can add this commit to .git-blame-ignore-revs as a follow-up.
sys/kern/device_if.m | ||
---|---|---|
70 | Since you're fixing style anyway |
sys/kern/device_if.m | ||
---|---|---|
52 | What about return braces? |
Comment Actions
Should I create a separate patch for this? I can not add it into the same patch since it changes git hash or I can just push it.
Comment Actions
Yes, it needs to be a separate patch. You can just go ahead and push that as a follow-up change.