Page MenuHomeFreeBSD

kern: fix incorrect format in device_if.m
ClosedPublic

Authored by aokblast on Aug 6 2025, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 6:48 AM
Unknown Object (File)
Sat, Oct 11, 6:48 AM
Unknown Object (File)
Sat, Oct 11, 6:48 AM
Unknown Object (File)
Sat, Oct 11, 6:48 AM
Unknown Object (File)
Fri, Oct 10, 11:31 PM
Unknown Object (File)
Thu, Oct 9, 9:32 PM
Unknown Object (File)
Fri, Oct 3, 6:49 PM
Unknown Object (File)
Fri, Oct 3, 10:55 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The tabbed indentation is correct. If anything, the other methods should be converted to use the correct style.

(Long long ago, subr_bus.c was indented using 4 spaces. That was fixed in commit 38c490a10f71c784fdbf2b8d663a83b78c23ced4, but this file was not updated.)

The tabbed indentation is correct. If anything, the other methods should be converted to use the correct style.

(Long long ago, subr_bus.c was indented using 4 spaces. That was fixed in commit 38c490a10f71c784fdbf2b8d663a83b78c23ced4, but this file was not updated.)

I thought it is some special format rule for .m files. Fix it now.

Approved

You can add this commit to .git-blame-ignore-revs as a follow-up.

sys/kern/device_if.m
70

Since you're fixing style anyway

This revision is now accepted and ready to land.Aug 6 2025, 1:34 PM

You can also put "no functional change." in the comment message if you want.

mhorne added inline comments.
sys/kern/device_if.m
52

What about return braces?

Approved

You can add this commit to .git-blame-ignore-revs as a follow-up.

Should I create a separate patch for this? I can not add it into the same patch since it changes git hash or I can just push it.

Approved

You can add this commit to .git-blame-ignore-revs as a follow-up.

Should I create a separate patch for this? I can not add it into the same patch since it changes git hash or I can just push it.

Yes, it needs to be a separate patch. You can just go ahead and push that as a follow-up change.

This revision was automatically updated to reflect the committed changes.