tcp: improve consistency of KASSERTs in tcp_sack.c
ClosedPublic
Actions

Authored by tuexen on Aug 4 2025, 7:45 PM.

Tags

None

Referenced Files

	F164966190: D51726.diff
	Wed, Aug 5, 3:53 AM

	Unknown Object (File)
	Sat, Aug 1, 4:02 PM

	Unknown Object (File)
	Sat, Aug 1, 3:30 PM

	Unknown Object (File)
	Tue, Jul 28, 3:12 AM

	Unknown Object (File)
	Sun, Jul 26, 9:24 PM

	Unknown Object (File)
	Fri, Jul 24, 3:24 PM

	Unknown Object (File)
	Sat, Jul 18, 9:40 AM

	Unknown Object (File)
	Jun 17 2026, 10:22 PM

Subscribers

Details

Reviewers

rscheff
rrs
nickbanks_netflix.com
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rGfeeb19201dca: tcp: improve consistency of KASSERTs in tcp_sack.c

Summary

When panicing, don't print the condition, which was violated, but the condition which holds at the time of the panic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 4 2025, 7:45 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 4 2025, 7:45 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Aug 4 2025, 7:45 PM

nickbanks_netflix.com accepted this revision.Aug 4 2025, 8:44 PM

This revision is now accepted and ready to land.Aug 4 2025, 8:44 PM

Closed by commit rGfeeb19201dca: tcp: improve consistency of KASSERTs in tcp_sack.c (authored by tuexen). · Explain WhyAug 6 2025, 8:30 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGfeeb19201dca: tcp: improve consistency of KASSERTs in tcp_sack.c.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_sack.c

30 lines

Diff 159832

View Options

tcp: improve consistency of KASSERTs in tcp_sack.cClosedPublicActions