Page MenuHomeFreeBSD

ufs: change isrmdir type to bool or u_int as appropriate
ClosedPublic

Authored by kib on Jul 29 2025, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 9:53 AM
Unknown Object (File)
Sun, Oct 12, 6:59 AM
Unknown Object (File)
Sat, Oct 11, 11:01 PM
Unknown Object (File)
Sat, Oct 11, 11:00 PM
Unknown Object (File)
Sat, Oct 11, 1:42 PM
Unknown Object (File)
Fri, Sep 26, 4:16 PM
Unknown Object (File)
Thu, Sep 25, 2:46 PM
Unknown Object (File)
Wed, Sep 24, 3:24 AM
Subscribers

Details

Summary
Use bool for isrmdir argument to
ufs_dirremove()/softdep_setup_remove()/newdirrem(), where it is used as
bool.

Use u_int for isrmdir argument to
ufs_dirrewrite()/softdep_setup_directory_change()
where it is 0/1/ino.  Without the change to unsigned, the
        if (isrmdir > 1)
test is broken on volumes with many inodes.
Use newparent instead of isrmdir for the argument name in this case.

Reviewed by:    markj
Fixes:  610319c766e941de96e52f2d28fea9f8cfc51aeb
Fixes:  98eb6f0eaa50d8bd9a6794f0a9da2eddeae5bcd8

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable