ifconfig/ifbridge.c: add get_vlan_id()
ClosedPublic
Actions

Authored by ivy on Jul 25 2025, 11:45 PM.

Tags

None

Referenced Files

	F154116928: D51548.id.diff
	Sun, Apr 26, 7:41 AM

	F154047132: D51548.id159164.diff
	Sat, Apr 25, 5:47 PM

	Unknown Object (File)
	Tue, Apr 21, 6:09 AM

	Unknown Object (File)
	Sat, Apr 18, 11:35 PM

	Unknown Object (File)
	Sat, Apr 11, 6:28 PM

	Unknown Object (File)
	Sat, Apr 11, 6:25 PM

	Unknown Object (File)
	Fri, Apr 10, 1:58 AM

	Unknown Object (File)
	Thu, Apr 2, 9:50 AM

View All 77 Files

Subscribers

imp

Details

Reviewers

des
kp

Commits

rG8b728c63f777: ifconfig/ifbridge.c: add get_vlan_id()
rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id()

Summary

This is like get_val() but takes an ether_vlanid_t* and ensures the
value is a valid VLAN ID. This avoids redundant comparisons and
casting when parsing VLAN IDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Jul 25 2025, 11:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 25 2025, 11:45 PM

ivy requested review of this revision.Jul 25 2025, 11:45 PM

Harbormaster completed remote builds in B65745: Diff 159164.Jul 25 2025, 11:45 PM

standalone version of D51244 in an attempt to land these bridge changes before 15.0.

des accepted this revision.Jul 28 2025, 2:08 PM

This revision is now accepted and ready to land.Jul 28 2025, 2:08 PM

Closed by commit rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id() (authored by ivy). · Explain WhyJul 28 2025, 2:10 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG287a5fdcd3c9: ifconfig/ifbridge.c: add get_vlan_id().

ivy added a commit: rG8b728c63f777: ifconfig/ifbridge.c: add get_vlan_id().Aug 23 2025, 12:12 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifbridge.c

28 lines

Diff 159319

View Options

ifconfig/ifbridge.c: add get_vlan_id()ClosedPublicActions