Website - new layout

[carlavilla]

Summary

Starting with Hugo 0.146.0 we have a new layout.

https://gohugo.io/templates/new-templatesystem-overview/#example-folder-structure

Test Plan

Apply the diff and execute make run

[lwhsu]

From 0.60.0 to 0.146.0 - it looks a leap! :-) Wanted to check two things:

• This needs using newer hugo to build, right? that means after applying this we need to update the www/doc site build backend immediately. If the newer hugo has backward compatibility then we can update the build backend first, that's even better.
• It seems the most of the add/delete come from directories partials and shortcodes named to _partials and _shortcodes, right? Just being curious the reason behind it (required by the new layout or it's recommended)? Is there any content got changed in the same time? If there is content modifications and path changes, perhaps it's worth to be done in two commits so it's easier to see what have been changed - do you mind to push to a git branch somewhere?

[carlavilla]

In D51539#1177114, @lwhsu wrote:

From 0.60.0 to 0.146.0 - it looks a leap! :-) Wanted to check two things:

• This needs using newer hugo to build, right? that means after applying this we need to update the www/doc site build backend immediately. If the newer hugo has backward compatibility then we can update the build backend first, that's even better.
• It seems the most of the add/delete come from directories partials and shortcodes named to _partials and _shortcodes, right? Just being curious the reason behind it (required by the new layout or it's recommended)? Is there any content got changed in the same time? If there is content modifications and path changes, perhaps it's worth to be done in two commits so it's easier to see what have been changed - do you mind to push to a git branch somewhere?

Well, the 0.60.0 it's not a big deal :)

About the change, is coz of this: https://gohugo.io/templates/new-templatesystem-overview/#example-folder-structure

About the upgrade in the cluster, you can update it to the latest version, in theory we're not gonna have any problem.

So it will be something like:

• Upgrade gohugo in the cluster to the latest version
• Make the commit

About the split in two reviews, why? We need to change everything at the same time

[lwhsu]

In D51539#1177115, @carlavilla wrote:

About the split in two reviews, why? We need to change everything at the same time

Note the condition mentioned -- if there is "path move" + "content change" then it's easier to have two commits, and thanks for git we can push two commits in the same time so it's still an atomic move. That's mainly for easier to check what has been modified.

[carlavilla]

In D51539#1177117, @lwhsu wrote:

In D51539#1177115, @carlavilla wrote:

About the split in two reviews, why? We need to change everything at the same time

Note the condition mentioned -- if there is "path move" + "content change" then it's easier to have two commits, and thanks for git we can push two commits in the same time so it's still an atomic move. That's mainly for easier to check what has been modified.

Ah, nothing changed.
I only renamed some folders and moved some files as the new hugo layout requieres.

But nothing else, no changes in the content

[lwhsu]

In D51539#1177145, @carlavilla wrote:

In D51539#1177117, @lwhsu wrote:

In D51539#1177115, @carlavilla wrote:

About the split in two reviews, why? We need to change everything at the same time

Note the condition mentioned -- if there is "path move" + "content change" then it's easier to have two commits, and thanks for git we can push two commits in the same time so it's still an atomic move. That's mainly for easier to check what has been modified.

Ah, nothing changed.
I only renamed some folders and moved some files as the new hugo layout requieres.

But nothing else, no changes in the content

ok, then I think it's fine after we have hugo updated in the backend.

[carlavilla]

@lwhsu I can confirm that you can update to the latest version of hugo.

Please, when you've done so, could you let me know here so I can commit it?

Thanks!!

[fernape]

LGTM

[mark_freebsdfoundation.org]

Renders correctly for me with local test too.

It'll be great to get up to date with Hugo before we look at 'new paint' :)

[mark_freebsdfoundation.org]

Hey folks. I was wondering when this commit might happen? It's a blocker to the site redesign work that @carlavilla is putting a lot of time into 😄 I'd love for this bit to drop so we can progress with the goal of 'new paint' by the time 15 drops. Thanks!

[carlavilla]

Fixed RSS