Page MenuHomeFreeBSD
Differential D51252

ifconfig: don't print bridge member ifmaxaddr if it's 0
ClosedPublic
Actions

Authored by ivy on Jul 11 2025, 7:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:51 PM
Unknown Object (File)
Sun, Oct 12, 12:50 AM
Unknown Object (File)
Sun, Oct 12, 12:49 AM
Unknown Object (File)
Sun, Oct 12, 12:49 AM
Unknown Object (File)
Sat, Oct 11, 3:19 PM
Unknown Object (File)
Sun, Sep 28, 5:03 AM
Unknown Object (File)
Fri, Sep 19, 5:19 AM
Unknown Object (File)
Sep 18 2025, 6:16 AM
View All 20 Files
Subscribers
imp
kp

Details

Reviewers
des
kevans
kp
Group Reviewers
network
Commits
rG763d1bc05a71: ifconfig: don't print bridge member ifmaxaddr if it's 0
Summary

Most bridge interfaces will have ifmaxaddr set to 0 (the default).
Save a little horizontal space by not printing it in this case.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Jul 11 2025, 7:06 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 11 2025, 7:06 AM
ivy requested review of this revision.Jul 11 2025, 7:06 AM
Harbormaster completed remote builds in B65344: Diff 158312.Jul 11 2025, 7:06 AM
ivy added a parent revision: D51245: tests/sys/net/if_bridge_test: fix MTU test.Jul 11 2025, 7:07 AM
ivy added a child revision: D51260: bridge: refactor local packet handling.Jul 11 2025, 12:16 PM
kp accepted this revision as: kp.Jul 12 2025, 12:14 PM
kp added a subscriber: kp.

On the one hand, this might break scripts if people try to parse ifconfig output. On the other hand, they really shouldn't.

This revision is now accepted and ready to land.Jul 12 2025, 12:14 PM
Closed by commit rG763d1bc05a71: ifconfig: don't print bridge member ifmaxaddr if it's 0 (authored by ivy). · Explain WhyJul 25 2025, 11:10 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG763d1bc05a71: ifconfig: don't print bridge member ifmaxaddr if it's 0.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
5 lines

Diff 159163

View Options

sbin/ifconfig/ifbridge.c

Loading...