shells/bash: Enable SYSBASHRC option by default

[michaelo]

Summary

Approved by: jrm (mentor), otis (mentor), ehaupt (maintainer)

[michaelo]

Discussed this via e-mail with @ehaupt in prior, I will take the fallout after the change.

[ehaupt]

Please commit as discussed previously. Thanks Michael.

[jrm]

Based on the UPDATING message, I assume this will only affect those who use bash as their login shell. It looks like shells/bash is a run dependency for a few hundred ports. Could you confirm that nothing changes for those with bash installed only because it's a dependency?

It looks like this simply /enables/ sourcing of the system-wide configuration file, but no configuration file is installed. Is that correct?

[michaelo]

In D51201#1169135, @jrm wrote:

Based on the UPDATING message, I assume this will only affect those who use bash as their login shell. It looks like shells/bash is a run dependency for a few hundred ports. Could you confirm that nothing changes for those with bash installed only because it's a dependency?

Not login shell, only interactive shell. Login shell only sources LOCALBASE/etc/profile. For those who don't have the system-wide RC file nothing changes.

It looks like this simply /enables/ sourcing of the system-wide configuration file, but no configuration file is installed. Is that correct?

Yes, that is correct. The file is up to the user. The default file is supplied. It just enables the obvious.

[jrm]

In D51201#1169141, @michaelo wrote:

The default file is supplied. It just enables the obvious.

Can you point me to this default configuration file (that will now be sourced?)? I don't see it.

root@15amd64-default:/usr/ports/shells/bash # pkg info bash | grep SYSBASHRC
        SYSBASHRC      : on
root@15amd64-default:/usr/ports/shells/bash # pkg info -l bash | grep '/etc'

[michaelo]

In D51201#1169157, @jrm wrote:

In D51201#1169141, @michaelo wrote:

The default file is supplied. It just enables the obvious.

Can you point me to this default configuration file (that will now be sourced?)? I don't see it.

root@15amd64-default:/usr/ports/shells/bash # pkg info bash | grep SYSBASHRC
        SYSBASHRC      : on
root@15amd64-default:/usr/ports/shells/bash # pkg info -l bash | grep '/etc'

Sorry for misleading you, bash uses the default path of LOCALBASE/etc/bash.bashrc, but the port does not provide one neither does bash itself.

This is patched for LOCALBASE: https://github.com/bminor/bash/blob/6794b5478f660256a1023712b5fc169196ed0a22/pathnames.h.in#L28
This one as well: https://github.com/bminor/bash/blob/6794b5478f660256a1023712b5fc169196ed0a22/config-top.h#L100

bash really makes a distinction being login or interactive or even running without a tty attached (scripted).