Differential D50893

tcp: Fix the SO_REUSEPORT_LB check
ClosedPublic
Actions

Authored by markj on Tue, Jun 17, 1:22 AM.

Details

Reviewers

glebius

Group Reviewers

transport

Commits

rGba3d547967c8: tcp: Fix the SO_REUSEPORT_LB check

Summary

This needs to happen in tcp_connect() rather than tcp_usr_connect(), as
the latter is reachable by implied connect() via sendto().

Reported by: syzbot+eecc86e6952fd9ba9f11@syzkaller.appspotmail.com
Fixes: c7f803c71dae ("inpcb: fix a panic with SO_REUSEPORT_LB + connect(2) misuse")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Jun 17, 1:22 AM

Herald added a reviewer: transport. · View Herald TranscriptTue, Jun 17, 1:22 AM

Herald added subscribers: melifaro, asomers, imp. · View Herald Transcript

markj requested review of this revision.Tue, Jun 17, 1:22 AM

Harbormaster completed remote builds in B64927: Diff 157152.Tue, Jun 17, 1:22 AM

glebius accepted this revision.Tue, Jun 17, 3:21 AM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 17, 11:28 AM

Closed by commit rGba3d547967c8: tcp: Fix the SO_REUSEPORT_LB check (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGba3d547967c8: tcp: Fix the SO_REUSEPORT_LB check.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

8 lines

tests/

sys/

netinet/

so_reuseport_lb_test.c

10 lines

Diff 157170

View Options

sys/netinet/tcp_usrreq.c