Page MenuHomeFreeBSD
Differential D50720

openzfs: Add a _WANT_ZNODE that defines struct znode / znode_t for userspace
ClosedPublic
Actions

Authored by jrtc27 on Jun 6 2025, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 7:53 AM
Unknown Object (File)
Tue, Oct 7, 4:59 AM
Unknown Object (File)
Sun, Oct 5, 4:23 AM
Unknown Object (File)
Fri, Oct 3, 6:47 AM
Unknown Object (File)
Thu, Oct 2, 1:13 AM
Unknown Object (File)
Sep 15 2025, 10:20 AM
Unknown Object (File)
Sep 15 2025, 4:26 AM
Unknown Object (File)
Sep 13 2025, 11:02 PM
View All 64 Files
Subscribers
delphij

Details

Reviewers
imp
kib
markj
mm
Commits
rGb4f9be7fb371: openzfs: Add a _WANT_ZNODE that defines struct znode / znode_t for userspace
Summary

Note that ZNODE_OS_FIELDS needs to change to using struct vnode over
vnode_t (matching struct zfsvfs rather than vnode_t) since vnode_t is
only defined in the kernel SPL, not the userspace SPL (libspl).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jun 6 2025, 2:15 PM
Herald added a subscriber: delphij. · View Herald TranscriptJun 6 2025, 2:15 PM
jrtc27 requested review of this revision.Jun 6 2025, 2:15 PM
Harbormaster completed remote builds in B64677: Diff 156637.Jun 6 2025, 2:15 PM
jrtc27 added a child revision: D50721: libprocstat: Drop zfs_defs.c hack, including its _KERNEL define.Jun 6 2025, 2:16 PM
imp accepted this revision.Jun 6 2025, 2:50 PM
This revision is now accepted and ready to land.Jun 6 2025, 2:50 PM
markj added inline comments.Jun 6 2025, 5:02 PM
sys/contrib/openzfs/include/os/freebsd/zfs/sys/zfs_znode_impl.h
197

Doesn't this need to be before the __cplusplus closing brace?

jrtc27 added inline comments.Jun 6 2025, 5:03 PM
sys/contrib/openzfs/include/os/freebsd/zfs/sys/zfs_znode_impl.h
197

Yes, thanks

jrtc27 updated this revision to Diff 156645.Jun 6 2025, 5:18 PM

Move endif

This revision now requires review to proceed.Jun 6 2025, 5:18 PM
Harbormaster completed remote builds in B64684: Diff 156645.Jun 6 2025, 5:18 PM
jrtc27 marked an inline comment as done.Jun 6 2025, 5:19 PM
markj accepted this revision.Jun 6 2025, 5:52 PM
This revision is now accepted and ready to land.Jun 6 2025, 5:52 PM
Closed by commit rGb4f9be7fb371: openzfs: Add a _WANT_ZNODE that defines struct znode / znode_t for userspace (authored by jrtc27). · Explain WhyJun 16 2025, 9:37 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGb4f9be7fb371: openzfs: Add a _WANT_ZNODE that defines struct znode / znode_t for userspace.

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
include/
os/
freebsd/
zfs/
sys/
9 lines
sys/
2 lines
5 lines

Diff 157139

View Options

sys/contrib/openzfs/include/os/freebsd/zfs/sys/zfs_znode_impl.h

Loading...
View Options

sys/contrib/openzfs/include/sys/zfs_vfsops.h

Loading...
View Options

sys/contrib/openzfs/include/sys/zfs_znode.h

Loading...