Page MenuHomeFreeBSD

sys/mount.h: Add missing headers so it's standalone for _WANT_MOUNT
ClosedPublic

Authored by jrtc27 on Jun 6 2025, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 5:36 AM
Unknown Object (File)
Sat, Oct 4, 5:30 AM
Unknown Object (File)
Sun, Sep 28, 5:01 AM
Unknown Object (File)
Sat, Sep 20, 10:05 PM
Unknown Object (File)
Sep 14 2025, 2:25 AM
Unknown Object (File)
Sep 13 2025, 8:55 PM
Unknown Object (File)
Sep 11 2025, 1:20 PM
Unknown Object (File)
Sep 10 2025, 6:17 AM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Jun 6 2025, 2:12 PM
jrtc27 created this revision.
This revision is now accepted and ready to land.Jun 6 2025, 2:46 PM

You need at least sys/types.h there as well.

In D50716#1158047, @kib wrote:

You need at least sys/types.h there as well.

Hm, isn't it more that there's an existing issue of sys/types.h not being explicitly included for normal userspace includes? All kinds of userspace-visible types are using uintN_t for example here. It just works because sys/ucred.h includes sys/types.h (and perhaps via other include chains too). I can definitely fix that, but I feel that should be a separate (precursor?) commit.

In D50716#1158047, @kib wrote:

You need at least sys/types.h there as well.

Hm, isn't it more that there's an existing issue of sys/types.h not being explicitly included for normal userspace includes? All kinds of userspace-visible types are using uintN_t for example here. It just works because sys/ucred.h includes sys/types.h (and perhaps via other include chains too). I can definitely fix that, but I feel that should be a separate (precursor?) commit.

I have no objections about sys/types.h being a preparational commit.