Page MenuHomeFreeBSD
Differential D50716

sys/mount.h: Add missing headers so it's standalone for _WANT_MOUNT
ClosedPublic
Actions

Authored by jrtc27 on Jun 6 2025, 2:12 PM.
Tags
None
Referenced Files
F157811395: D50716.id157134.diff
Mon, May 25, 11:14 AM
Unknown Object (File)
Tue, May 12, 4:08 PM
Unknown Object (File)
Mon, May 11, 10:23 PM
Unknown Object (File)
Mon, May 11, 9:35 PM
Unknown Object (File)
Mon, May 11, 8:59 PM
Unknown Object (File)
Thu, May 7, 7:43 AM
Unknown Object (File)
Mon, Apr 27, 4:25 PM
Unknown Object (File)
Apr 21 2026, 1:15 AM
View All 72 Files
Subscribers
None

Details

Reviewers
imp
kib
markj
mjg
Commits
rGb1e67144058d: sys/mount.h: Add missing headers so it's standalone for _WANT_MOUNT

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Jun 6 2025, 2:12 PM
jrtc27 created this revision.
Harbormaster completed remote builds in B64673: Diff 156633.Jun 6 2025, 2:13 PM
jrtc27 added a child revision: D50719: libprocstat: Drop all _KERNEL defines outside of zfs_defs.c.Jun 6 2025, 2:16 PM
imp accepted this revision.Jun 6 2025, 2:46 PM
This revision is now accepted and ready to land.Jun 6 2025, 2:46 PM
markj accepted this revision.Jun 6 2025, 4:22 PM
markj mentioned this in D50718: msdosfs: Add _WANT_MSDOSFS_INTERNALS to replace MAKEFS in headers.Jun 6 2025, 4:26 PM
kib added a comment.Jun 7 2025, 5:28 AM

You need at least sys/types.h there as well.

jrtc27 added a comment.Jun 7 2025, 6:27 PM
In D50716#1158047, @kib wrote:

You need at least sys/types.h there as well.

Hm, isn't it more that there's an existing issue of sys/types.h not being explicitly included for normal userspace includes? All kinds of userspace-visible types are using uintN_t for example here. It just works because sys/ucred.h includes sys/types.h (and perhaps via other include chains too). I can definitely fix that, but I feel that should be a separate (precursor?) commit.

kib added a comment.Jun 8 2025, 3:00 AM
In D50716#1158126, @jrtc27 wrote:
In D50716#1158047, @kib wrote:

You need at least sys/types.h there as well.

Hm, isn't it more that there's an existing issue of sys/types.h not being explicitly included for normal userspace includes? All kinds of userspace-visible types are using uintN_t for example here. It just works because sys/ucred.h includes sys/types.h (and perhaps via other include chains too). I can definitely fix that, but I feel that should be a separate (precursor?) commit.

I have no objections about sys/types.h being a preparational commit.

kib accepted this revision.Jun 8 2025, 3:01 AM
jrtc27 added a parent revision: D50884: sys/mount.h: Hoist sys/types.h include.Jun 16 2025, 7:53 PM
Closed by commit rGb1e67144058d: sys/mount.h: Add missing headers so it's standalone for _WANT_MOUNT (authored by jrtc27). · Explain WhyJun 16 2025, 9:37 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGb1e67144058d: sys/mount.h: Add missing headers so it's standalone for _WANT_MOUNT.

Revision Contents
Changeset List

PathSize
sys/
sys/
4 lines

Diff 157134

View Options

sys/sys/mount.h

Loading...