Page MenuHomeFreeBSD

rcorder: add some primitive tests
AcceptedPublic

Authored by kevans on May 28 2025, 12:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 11:28 PM
Unknown Object (File)
Sat, Sep 27, 9:49 PM
Unknown Object (File)
Fri, Sep 19, 1:23 PM
Unknown Object (File)
Sep 13 2025, 5:36 AM
Unknown Object (File)
Sep 11 2025, 8:29 AM
Unknown Object (File)
Sep 7 2025, 8:02 AM
Unknown Object (File)
Sep 2 2025, 11:22 AM
Unknown Object (File)
Aug 18 2025, 12:29 AM

Details

Reviewers
ivy
brooks
olce
Group Reviewers
tests
Summary

Test basic PROVIDES/REQUIRE functionality, as well as various keyword
operations. Also document, via a test, the current behavior when a
REQUIRE is missing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64482
Build 61366: arc lint + arc unit

Event Timeline

I've not worked through every case, but over all looks good.

This revision is now accepted and ready to land.May 28 2025, 7:30 PM

Correct me if I'm wrong, but doesn't this rely on the fts order returned by the filesystem? If so, it seems like it would be better to explicitly list which files should be included by appending the files to a variable, then passing that variable to rcorder.

Correct me if I'm wrong, but doesn't this rely on the fts order returned by the filesystem? If so, it seems like it would be better to explicitly list which files should be included by appending the files to a variable, then passing that variable to rcorder.

The shell glob is expected to reliably sort by the current collation; I went with all lowercase filenames to avoid any surprises for weird locales, but we could probably export LANG=C to remove all doubt

Correct me if I'm wrong, but doesn't this rely on the fts order returned by the filesystem? If so, it seems like it would be better to explicitly list which files should be included by appending the files to a variable, then passing that variable to rcorder.

The shell glob is expected to reliably sort by the current collation; I went with all lowercase filenames to avoid any surprises for weird locales, but we could probably export LANG=C to remove all doubt

👍