Page MenuHomeFreeBSD

qat.4: Cleanup
ClosedPublic

Authored by ziaee on May 16 2025, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:58 AM
Unknown Object (File)
Sun, Oct 5, 12:45 AM
Unknown Object (File)
Fri, Oct 3, 8:49 AM
Unknown Object (File)
Fri, Oct 3, 6:11 AM
Unknown Object (File)
Fri, Oct 3, 4:43 AM
Unknown Object (File)
Thu, Oct 2, 2:56 PM
Unknown Object (File)
Wed, Oct 1, 1:04 AM
Unknown Object (File)
Wed, Sep 24, 7:32 AM
Subscribers

Details

Summary

+ copyright symbols do not belong in Nd's (apropos results)
+ move hardware to HARDWARE for inclusion in the hw release notes
+ lines which say nothing removed
+ links moved to see also
+ spacing and markup corrections

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee requested review of this revision.May 16 2025, 5:23 PM

Markj asked to be cc on all qat changes.

share/man/man4/qat.4
42
108

This is not the same uio.

177

I don't understand the reference to 13.5: the original qat driver was indeed in 13.0.

Overall it is a clear improvement.

share/man/man4/qat.4
41–43

These two statements are more closely related. Alternatively, each can be its own paragraph.

116

You might bump the width here. Currently every description in the list is pushed to the second line, so this would help visually.

ziaee marked 3 inline comments as done.

address markj feedback, thank you so much!

address mhorne's feedback; improve sysctls so that the complete sysctl
is more easily searchable with apropos.

ziaee added inline comments.
share/man/man4/qat.4
41–43

Fixed. I think they should really be rewritten to one statement. I think also the description could use some more detail, like, qat supports zfs gzip compression, and readers probably want to know that.

116

I wasn't sure what to do with it because I think that these sysctls actually need the prefix so they're more easily searchable with apropos.

177

Fixed. Sorry, the oldest commit I found said it was in 13.5 with git branch --contains.

This revision is now accepted and ready to land.May 16 2025, 8:33 PM

Thank you so much gentlemen, we will put this in the hardware release notes!

This revision was automatically updated to reflect the committed changes.