Page MenuHomeFreeBSD
Differential D50249

vm_page: reorder declarations in header file
ClosedPublic
Actions

Authored by dougm on Wed, May 7, 10:06 PM.
Tags
None
Referenced Files
F119040740: D50249.id155118.diff
Wed, Jun 4, 4:27 PM
Unknown Object (File)
Sat, May 31, 1:34 AM
Unknown Object (File)
Thu, May 29, 11:58 PM
Unknown Object (File)
Mon, May 12, 8:02 PM
Subscribers
imp

Details

Reviewers
alc
kib
markj
Commits
rGd23b3bbdd44f: vm_page: alphabetize declarations
Summary

Make a range of function declarations in vm_page.h more nearly alphabetically sorted.

Some are still left out, like functions involving KBI.

Should we be naming parameters here, or not?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Wed, May 7, 10:06 PM
dougm created this revision.
dougm edited the summary of this revision. (Show Details)Fri, May 9, 3:30 AM
dougm added reviewers: kib, markj.
kib accepted this revision.Fri, May 9, 7:09 AM
This revision is now accepted and ready to land.Fri, May 9, 7:09 AM
alc accepted this revision.Mon, May 12, 6:47 PM
alc added inline comments.
sys/vm/vm_page.h
604–605

The majority of the declarations that are migrating to a new place in the list have parameter names. Can we add parameter names to the rest of those that are migrating?

Closed by commit rGd23b3bbdd44f: vm_page: alphabetize declarations (authored by dougm). · Explain WhyMon, May 12, 8:02 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGd23b3bbdd44f: vm_page: alphabetize declarations.
Herald added a subscriber: imp. · View Herald TranscriptMon, May 12, 8:02 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
39 lines

Diff 155351

View Options

sys/vm/vm_page.h

Loading...