Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | ||
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | I believe that should also be !_KERNEL, while we're at it... the positive form would go on the #endif, traditionally | |
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | That would also mean that line 87 is reversed, looking at the context. There are some other wrong examples in sys/sys/*.h, maybe we should do a pass and normalize to what style(9) wants. | |
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | I checked what diff -D_KERNEL would do and the #else needs a ! but line 87 is fine, since it closes the !_KERNEL section. | |
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | We should update style(9), then... the #endif comments in both of the COMPAT_43 examples there strictly match the original condition. | |
| sys/net/if_dl.h | ||
|---|---|---|
| 78 | Yeah style(9) matches what I'm used to seeing. Not sure if diff is broken or if they've always disagreed. The logical side of me wants to follow the tooling, the practical side of me doesn't want to change 30+ years of precedent. | |