Page MenuHomeFreeBSD
Differential D49774

sys: protect the kernel build from accidental _FORTIFY_SOURCE
ClosedPublic
Actions

Authored by kevans on Apr 11 2025, 3:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 4:31 AM
Unknown Object (File)
Mon, Oct 20, 5:02 PM
Unknown Object (File)
Sep 20 2025, 3:56 PM
Unknown Object (File)
Sep 20 2025, 5:13 AM
Unknown Object (File)
Sep 17 2025, 2:50 AM
Unknown Object (File)
Sep 15 2025, 1:19 PM
Unknown Object (File)
Sep 14 2025, 6:19 PM
Unknown Object (File)
Sep 10 2025, 9:11 PM
View All 39 Files
Subscribers
glebius
guest-patmaddox
imp
jlduran

Details

Reviewers
markj
emaste
imp
Commits
rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE
Summary

Fortification is a userland feature, thus the flag makes no sense in a
kernel context at the moment. Move the relevant includes that aren't
already in a !_KERNEL block under a !_KERNEL condition to avoid breaking
kernel/kmod builds that are catching a stray -D_FORTIFY_SOURCE in their
CFLAGS.

PR: 286010

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Apr 11 2025, 3:33 AM
Herald added subscribers: glebius, imp. · View Herald TranscriptApr 11 2025, 3:33 AM
kevans requested review of this revision.Apr 11 2025, 3:33 AM
Harbormaster completed remote builds in B63447: Diff 153493.Apr 11 2025, 3:33 AM
guest-patmaddox added a subscriber: guest-patmaddox.Apr 11 2025, 3:39 AM
jlduran added a subscriber: jlduran.Apr 11 2025, 12:04 PM
markj accepted this revision.Apr 11 2025, 1:33 PM
markj added inline comments.
sys/sys/poll.h
112 ↗(On Diff #153493)

We're already in a ifndef _KERNEL block here.

This revision is now accepted and ready to land.Apr 11 2025, 1:33 PM
kevans added inline comments.Apr 11 2025, 2:10 PM
sys/sys/poll.h
112 ↗(On Diff #153493)

Whoops, missed that; will remove, thanks.

emaste accepted this revision.Apr 11 2025, 2:19 PM
imp accepted this revision.Apr 11 2025, 2:22 PM
imp added inline comments.
sys/sys/poll.h
112 ↗(On Diff #153493)

my approval is conditional on dropping this one change.

Closed by commit rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE (authored by kevans). · Explain WhyApr 12 2025, 1:54 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE.

Revision Contents
Changeset List

PathSize
sys/
sys/
10 lines
2 lines
4 lines

Diff 153560

View Options

sys/sys/random.h

Loading...
View Options

sys/sys/select.h

Loading...
View Options

sys/sys/socket.h

Loading...