route: use NH_IS_VALID macro consistently
ClosedPublic
Actions

Authored by franco_opnsense.org on Mar 14 2025, 7:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 7, 1:13 AM

	Unknown Object (File)
	Tue, Sep 1, 7:56 PM

	Unknown Object (File)
	Tue, Sep 1, 1:14 AM

	Unknown Object (File)
	Tue, Aug 25, 3:19 PM

	Unknown Object (File)
	Sun, Aug 23, 11:16 AM

	Unknown Object (File)
	Thu, Aug 20, 3:20 AM

	Unknown Object (File)
	Wed, Aug 19, 12:04 PM

	Unknown Object (File)
	Aug 10 2026, 9:21 AM

Subscribers

Details

Reviewers

melifaro
markj
glebius

Summary

Mimimize exposure of the RT_LINK_IS_UP macro since
all of its callers are within NH scope and remove
the superfluous comments.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 62914
Build 59798: arc lint + arc unit

Event Timeline

franco_opnsense.org requested review of this revision.Mar 14 2025, 7:23 AM

franco_opnsense.org created this revision.

Harbormaster completed remote builds in B62914: Diff 152248.Mar 14 2025, 7:23 AM

franco_opnsense.org mentioned this in D49212: route: protect against unattached if_afdata.Mar 14 2025, 7:25 AM

melifaro accepted this revision.Mar 14 2025, 7:38 AM

This revision is now accepted and ready to land.Mar 14 2025, 7:38 AM

I trust Alexander's opinion on this.

This was addressed in commit d05d1f2560823 by @pouria .

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_fib.c

9 lines

netinet6/

in6_fib.c

9 lines

Diff 152248

View Options

sys/netinet/in_fib.c