Differential D48971

gve: Disallow MTUs within a problematic range
ClosedPublic
Actions

Authored by jtranoleary_google.com on Wed, Feb 12, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 5:00 PM

Subscribers

Details

Reviewers

markj
delphij
kibab
shailend_google.com

Group Reviewers

Commits

rG909e2d7b691f: gve: Disallow MTUs within a problematic range

Summary

If hardware LRO is enabled with GVE, then setting the driver's MTU to a
range of values around 8000 will cause dropped packets and drastically
degraded performance. While this issue is being investigated, we need
to prohibit the driver's MTU being set to a value within this range.

Signed-off-by: Jasper Tran O'Leary <jtranoleary@google.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtranoleary_google.com created this revision.Wed, Feb 12, 6:20 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 12, 6:20 PM

jtranoleary_google.com requested review of this revision.Wed, Feb 12, 6:20 PM

Harbormaster completed remote builds in B62402: Diff 150918.Wed, Feb 12, 6:20 PM

jtranoleary_google.com added a child revision: D48970: gve: Fix memory leak during reset.Wed, Feb 12, 6:38 PM

delphij accepted this revision.Thu, Feb 13, 8:47 AM

This revision is now accepted and ready to land.Thu, Feb 13, 8:47 AM

markj accepted this revision as: markj.Thu, Feb 13, 2:54 PM

Closed by commit rG909e2d7b691f: gve: Disallow MTUs within a problematic range (authored by jtranoleary_google.com, committed by markj). · Explain WhyFri, Feb 14, 3:11 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG909e2d7b691f: gve: Disallow MTUs within a problematic range.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gve/

15 lines

Diff 151024

sys/dev/gve/gve_main.c

Loading...