rpcsec_tls: cleanup the rpctls_syscall()
Needs ReviewPublic
Actions

Authored by glebius on Fri, Jan 24, 7:35 AM.

Details

Reviewers

rmacklem
brooks

Group Reviewers

network

Summary

With all the recent changes we don't need extra argument that specifies
what exactly the syscalls does, neither we need a copyout-able pointer,
just a pointer sized integer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61971
Build 58855: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Jan 24, 7:35 AM

Herald added a reviewer: brooks. · View Herald TranscriptFri, Jan 24, 7:35 AM

Herald added subscribers: olce, imp. · View Herald Transcript

glebius requested review of this revision.Fri, Jan 24, 7:35 AM

Harbormaster completed remote builds in B61971: Diff 149863.Fri, Jan 24, 7:35 AM

glebius added a parent revision: D48570: rpc.tlsservd: provide parallelism with help of pthread(3).Fri, Jan 24, 7:35 AM

markj added a subscriber: markj.Fri, Jan 24, 4:35 PM

markj added inline comments.

sys/kern/syscalls.master
3252	What happens if one runs an old rpc.tlsservd with a new kernel?

glebius marked an inline comment as done.Fri, Jan 24, 4:59 PM

glebius added inline comments.

sys/kern/syscalls.master
3252	The syscall will return EINVAL. I don't know if the syscall argument parsing layer will do that or it will actually enter sys_rpctls_syscall(). If the latter happens, the small value that previously meant a command would be used as socookie and looked up in the database of stored sockets, and of course that lookup would fail.