riscv: Add the sdhci_fdt driver to the build
AcceptedPublic
Actions

Authored by bnovkov on Jan 20 2025, 6:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 19, 8:29 PM

	Unknown Object (File)
	Wed, Feb 5, 1:58 AM

	Unknown Object (File)
	Tue, Feb 4, 6:15 PM

	Unknown Object (File)
	Sun, Feb 2, 9:24 PM

	Unknown Object (File)
	Fri, Jan 31, 6:24 PM

	Unknown Object (File)
	Fri, Jan 31, 1:34 AM

	Unknown Object (File)
	Thu, Jan 30, 6:58 PM

	Unknown Object (File)
	Tue, Jan 28, 9:29 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

br
imp

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Jan 20 2025, 6:42 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2025, 6:42 PM

bnovkov requested review of this revision.Jan 20 2025, 6:43 PM

Queue rant about how we're doing this wrong.. but that's an issue for config-ng, not this review

This revision is now accepted and ready to land.Jan 20 2025, 6:56 PM

br added inline comments.Jan 20 2025, 7:18 PM

sys/modules/Makefile
715	should be 4 spaces I think, not a tab

bnovkov added inline comments.Sat, Jan 25, 6:37 PM

sys/modules/Makefile
715	Hm, after a quick look it seems that both 4 spaces and tabs are used for breaking longer lines in this makefile. I don't have a preference for this one and can change it to 4 spaces if you want. Maybe this would be a good time to settle on one approach and make the style consistent in a separate commit?

Revision Contents
Changeset List

Path

Size

sys/

modules/

Makefile

3 lines

Diff 149577

View Options

riscv: Add the sdhci_fdt driver to the buildAcceptedPublicActions