Page MenuHomeFreeBSD
Differential D48023

cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean
ClosedPublic
Actions

Authored by jhb on Dec 10 2024, 7:46 PM.
Tags
None
Referenced Files
F153747747: D48023.id.diff
Thu, Apr 23, 9:57 AM
Unknown Object (File)
Mon, Apr 20, 1:39 AM
Unknown Object (File)
Sat, Apr 18, 8:24 PM
Unknown Object (File)
Thu, Apr 16, 3:35 AM
Unknown Object (File)
Tue, Apr 14, 10:25 PM
Unknown Object (File)
Sat, Apr 11, 8:05 PM
Unknown Object (File)
Wed, Apr 8, 6:46 AM
Unknown Object (File)
Tue, Apr 7, 3:26 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG939bcd2c20b4: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean
rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean
Summary

This is intended to clean state of a thread at the end of its
lifecycle during wait(), not the beginning of its life cycle.

Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 10 2024, 7:46 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 10 2024, 7:46 PM
jhb requested review of this revision.Dec 10 2024, 7:46 PM
jhb added a parent revision: D48022: cpu_machdep.9: New manpage describing the semantics of several cpu_*.
Harbormaster completed remote builds in B61075: Diff 147790.Dec 10 2024, 7:46 PM
kib added a comment.Dec 11 2024, 3:46 PM

amd64 cpu_set_upcall() also calls cpu_thread_clean(), basically for the fresh thread. I suspect this call was copied.

kib accepted this revision.Dec 11 2024, 3:46 PM
This revision is now accepted and ready to land.Dec 11 2024, 3:46 PM
jhb retitled this revision from linux_clone_thread: Remove call to cpu_thread_clean to cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean.Jan 2 2025, 5:28 PM
In D48023#1094794, @kib wrote:

amd64 cpu_set_upcall() also calls cpu_thread_clean(), basically for the fresh thread. I suspect this call was copied.

Oof, so does i386. Not sure how I missed those. Thanks.

jhb updated this revision to Diff 148681.Jan 2 2025, 5:29 PM

Remove from cpu_set_upcall

This revision now requires review to proceed.Jan 2 2025, 5:29 PM
Harbormaster completed remote builds in B61462: Diff 148681.Jan 2 2025, 5:29 PM
kib accepted this revision.Jan 3 2025, 11:45 AM
This revision is now accepted and ready to land.Jan 3 2025, 11:45 AM
Closed by commit rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean (authored by jhb). · Explain WhyJan 3 2025, 4:03 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean.
jhb added a commit: rG939bcd2c20b4: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean.Mar 3 2025, 4:58 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
10 lines
compat/
linux/
2 lines
i386/
i386/
10 lines

Diff 148734

View Options

sys/amd64/amd64/vm_machdep.c

Loading...
View Options

sys/compat/linux/linux_fork.c

Loading...
View Options

sys/i386/i386/vm_machdep.c

Loading...