Details

Reviewers

jlduran
imp
markj
tuexen

Summary

Stop probing after receiving ICMP6_DST_UNREACH.

The behavior can be observed by tracing the route to
2a02:ee80:4028:1126::

Discussed with: Job Snijders, Nick Hilliard
Obtained from: OpenBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60500
Build 57384: arc lint + arc unit

Event Timeline

otis requested review of this revision.Mon, Nov 11, 10:43 PM

otis created this revision.

Harbormaster completed remote builds in B60493: Diff 146294.Mon, Nov 11, 10:43 PM

Not that it matters, but Linux also does this.
Thank you for the patch!

This revision is now accepted and ready to land.Tue, Nov 12, 12:52 AM

Ah... this will require an entry in traceroute6.8 (right before EXIT STATUS), but it can be done before committing, if others also accept this patch.

Print !R on route rejected error and update manual page.

This revision now requires review to proceed.Tue, Nov 12, 8:36 AM

Harbormaster completed remote builds in B60497: Diff 146309.Tue, Nov 12, 8:36 AM

Update manpage date

Harbormaster completed remote builds in B60498: Diff 146310.Tue, Nov 12, 8:37 AM

Just a couple remarks:

usr.sbin/traceroute6/traceroute6.8
194	I still have hopes of unifying `traceroute` and `traceroute6`... while `!R` is not used by `traceroute`, ideally both should print the same annotations (they do not), or just the "common" ones. If you and the other reviewers don't mind, I would prefer just to add a catch-all (default) case to the switch. At some point a letter for each type/code does not add more clarity IMO. However, if you still think this should deserve its own letter, I won't object.
196	.It !<num> ICMP unreachable code <num>. To match `traceroute(8)`?

otis marked 2 inline comments as done.Tue, Nov 12, 1:53 PM

otis added inline comments.

usr.sbin/traceroute6/traceroute6.8
194	I still have hopes of unifying `traceroute` and `traceroute6`... while `!R` is not used by `traceroute`, ideally both should print the same annotations (they do not), or just the "common" ones. This is valid point, I'll abandon `!R` for now, keeping `!<num>`. And let's do unifying both `traceroute`s as next step (I also considered that option). If you and the other reviewers don't mind, I would prefer just to add a catch-all (default) case to the switch. At some point a letter for each type/code does not add more clarity IMO. However, if you still think this should deserve its own letter, I won't object. I'm indifferent, too.