Report max protection for vm_map_entry in ptrace(PTRACE_VM_ENTRY) and kinfo_vmentry
ClosedPublic
Actions

Authored by kib on Oct 7 2024, 8:38 AM.

Details

Reviewers

markj
emaste
brooks

Commits

rGe90b2b7d6c17: ptrace(PT_VM_ENTRY): report max protection
rG409c2fa385aa: kinfo_vmentry: report max protection

Summary

procstat bits are not included, I think it will go as a separate column in procstat vm output, hidden under a flag to not break the output format by default

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Oct 7 2024, 8:38 AM

Herald added subscribers: olce, imp. · View Herald TranscriptOct 7 2024, 8:38 AM

kib requested review of this revision.Oct 7 2024, 8:38 AM

procstat bits are not included, I think it will go as a separate column in procstat vm output, hidden under a flag to not break the output format by default

In CheriBSD, procstat vm has a -v option to enable some extra columns, so I would suggest using that for maxprot.

markj accepted this revision.Oct 7 2024, 12:05 PM

This revision is now accepted and ready to land.Oct 7 2024, 12:05 PM

brooks added inline comments.Oct 8 2024, 5:41 AM

sys/sys/user.h
509–511	I'd rather these start from 0x00010000 like PROT_MAX(PROT_READ). We've added two additional port bits in CheriBSD and it would be annoying to interleave MAX and regular PROTs.