ctl_report_supported_opcodes: Rename invalid label to invalid_options
ClosedPublic
Actions

Authored by jhb on Sep 24 2024, 4:32 PM.

Details

Reviewers

asomers
imp
emaste

Group Reviewers

cam

Commits

rGc93b892f71cf: ctl_report_supported_opcodes: Rename invalid label to invalid_options
rG159756c6add9: ctl_report_supported_opcodes: Rename invalid label to invalid_options
rG0063ef79f9e6: ctl_report_supported_opcodes: Rename invalid label to invalid_options

Summary

This error handling is specific to an invalid value in the REPORTING
OPTIONS field of a REPORT SUPPORTED OPERATION CODES command.

While here, reuse the label for another case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 24 2024, 4:32 PM

Herald added a reviewer: cam. · View Herald TranscriptSep 24 2024, 4:32 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Sep 24 2024, 4:32 PM

Harbormaster completed remote builds in B59582: Diff 143677.Sep 24 2024, 4:32 PM

jhb added a child revision: D46611: ctl_report_supported_opcodes: Handle invalid requested service action.Sep 24 2024, 4:32 PM

imp accepted this revision as: imp.Sep 24 2024, 8:21 PM

This revision is now accepted and ready to land.Sep 24 2024, 8:21 PM

emaste accepted this revision.Sep 25 2024, 12:03 PM

Closed by commit rG0063ef79f9e6: ctl_report_supported_opcodes: Rename invalid label to invalid_options (authored by jhb). · Explain WhySep 25 2024, 2:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0063ef79f9e6: ctl_report_supported_opcodes: Rename invalid label to invalid_options.

jhb added a commit: rG159756c6add9: ctl_report_supported_opcodes: Rename invalid label to invalid_options.Dec 1 2024, 4:57 AM

jhb added a commit: rGc93b892f71cf: ctl_report_supported_opcodes: Rename invalid label to invalid_options.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl.c

15 lines

Diff 143710

View Options

ctl_report_supported_opcodes: Rename invalid label to invalid_optionsClosedPublicActions