if_ovpn: remove unused argument
ClosedPublic
Actions

Authored by kp on Sep 9 2024, 9:36 PM.

Tags

None

Referenced Files

	F167205610: D46615.id143185.diff
	Wed, Aug 19, 10:43 PM

	Unknown Object (File)
	Tue, Aug 11, 9:32 AM

	Unknown Object (File)
	Tue, Aug 11, 9:22 AM

	Unknown Object (File)
	Wed, Aug 5, 9:15 AM

	Unknown Object (File)
	Wed, Aug 5, 5:29 AM

	Unknown Object (File)
	Tue, Aug 4, 6:42 AM

	Unknown Object (File)
	Tue, Jul 21, 2:46 AM

	Unknown Object (File)
	Jul 20 2026, 11:37 PM

Subscribers

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rGda1a1ad062a2: if_ovpn: remove unused argument

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 9 2024, 9:36 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 9 2024, 9:36 PM

kp requested review of this revision.Sep 9 2024, 9:36 PM

Harbormaster completed remote builds in B59413: Diff 143160.Sep 9 2024, 9:36 PM

kp added a child revision: D46616: if_ovpn: avoid LOR between ovpn and UDP locks.Sep 9 2024, 9:36 PM

Looks good to me.

sys/net/if_ovpn.c
382	Does not the compiler complains this unused argument ?

This revision is now accepted and ready to land.Sep 10 2024, 9:46 AM

kp added inline comments.Sep 10 2024, 9:55 AM

sys/net/if_ovpn.c
382	It did not. I'm not sure why. Perhaps because it's a static function and wound up inlined?

Closed by commit rGda1a1ad062a2: if_ovpn: remove unused argument (authored by kp). · Explain WhySep 10 2024, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGda1a1ad062a2: if_ovpn: remove unused argument.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_ovpn.c

4 lines

Diff 143185

View Options

if_ovpn: remove unused argumentClosedPublicActions