Page MenuHomeFreeBSD

pfctl: pfik_ifp is always NULL
ClosedPublic

Authored by kp on Aug 16 2024, 1:51 PM.
Tags
None
Referenced Files
F102558594: D46311.diff
Thu, Nov 14, 1:27 AM
F102556900: D46311.diff
Thu, Nov 14, 12:51 AM
Unknown Object (File)
Sun, Oct 20, 9:16 PM
Unknown Object (File)
Oct 8 2024, 1:57 PM
Unknown Object (File)
Oct 3 2024, 1:28 AM
Unknown Object (File)
Oct 2 2024, 11:58 PM
Unknown Object (File)
Sep 30 2024, 4:26 PM
Unknown Object (File)
Sep 27 2024, 9:00 AM

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG6a88e22728d2: pfctl: pfik_ifp is always NULL
Summary

The pfik_ifp field is not provided by the kernel, it is always NULL. Do not
check for it. This caused us to not clear the skip flag on interfaces, leading
to unexpected behaviour when a 'set skip' was removed.

PR: 280834
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59040
Build 55927: arc lint + arc unit

Event Timeline

kp requested review of this revision.Aug 16 2024, 1:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2024, 4:03 PM
This revision was automatically updated to reflect the committed changes.