Page MenuHomeFreeBSD
Differential D46311

pfctl: pfik_ifp is always NULL
ClosedPublic
Actions

Authored by kp on Aug 16 2024, 1:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 17, 12:12 PM
Unknown Object (File)
Jan 27 2025, 4:59 PM
Unknown Object (File)
Jan 27 2025, 4:53 PM
Unknown Object (File)
Jan 16 2025, 5:06 AM
Unknown Object (File)
Jan 1 2025, 1:50 AM
Unknown Object (File)
Dec 29 2024, 8:50 AM
Unknown Object (File)
Dec 2 2024, 6:06 PM
Unknown Object (File)
Nov 22 2024, 1:40 AM
View All 32 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG6a88e22728d2: pfctl: pfik_ifp is always NULL
Summary

The pfik_ifp field is not provided by the kernel, it is always NULL. Do not
check for it. This caused us to not clear the skip flag on interfaces, leading
to unexpected behaviour when a 'set skip' was removed.

PR: 280834
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Aug 16 2024, 1:51 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptAug 16 2024, 1:51 PM
kp requested review of this revision.Aug 16 2024, 1:51 PM
Harbormaster completed remote builds in B59040: Diff 142126.Aug 16 2024, 1:51 PM
zlei added a subscriber: zlei.Aug 16 2024, 2:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2024, 4:03 PM
Closed by commit rG6a88e22728d2: pfctl: pfik_ifp is always NULL (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG6a88e22728d2: pfctl: pfik_ifp is always NULL.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
7 lines
tests/
sys/
netpfil/
pf/
61 lines

Diff 142173

View Options

sbin/pfctl/pfctl.c

Loading...
View Options

tests/sys/netpfil/pf/set_skip.sh

Loading...