Page MenuHomeFreeBSD

rtld-elf: Pass parsed aux_info to ifunc_init
ClosedPublic

Authored by jrtc27 on Aug 13 2024, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 16, 1:24 PM
Unknown Object (File)
Fri, May 16, 11:30 AM
Unknown Object (File)
Tue, May 13, 9:05 PM
Unknown Object (File)
Fri, May 2, 12:16 AM
Unknown Object (File)
Tue, Apr 29, 5:47 PM
Unknown Object (File)
Tue, Apr 29, 11:21 AM
Unknown Object (File)
Tue, Apr 29, 3:55 AM
Unknown Object (File)
Thu, Apr 24, 12:38 PM
Subscribers

Details

Summary

Currently we pass the raw pointer to the on-stack auxargs. This can
legitimately have fewer than AT_COUNT entries, so the use of
__min_size(AT_COUNT), i.e. static AT_COUNT, is inaccurate, and also
needlessly forces the callee to iterate over the elements to find the
entry for a given type. Instead we can just pass aux_info like we use
for everything else.

Note that the argument has been left unused by every callee since its
introduction in 4352999e0e6c ("Pass CPUID[1] %edx (cpu_feature), %ecx
(cpu_feature2) and CPUID[7].%ebx (cpu_stdext_feature), %ecx
(cpu_stdext_feature2) to the ifunc resolvers on x86.")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable