Murmur3 implementation by des@ to replace Jenkins hash

[gnn]

Summary

Previous version of Murmur3 patch had several issues. Dag-Egling graciously stepped forward with his own implmentation.

[gnn]

Typo in the flowtable call of murmur3

[des]

You replaced the original diff with a new diff relative to the old one. This makes it impossible to comment on the complete diff.

[gnn]

You need to click Diff1 to see the original diff.

[des]

In D461#6, @gnn wrote:

You need to click Diff1 to see the original diff.

That's not very useful. I don't want to see the original diff, I want to see the complete diff.

[gnn]

Try to get a single diff in place using the arc update command.

[des]

sys/libkern/murmur3_32.c

28–31

<sys/types.h> should always come first, and <sys/stdint.h> is redundant.

85

<string.h> isn't needed.

sys/sys/hash.h

123–126

The comment should note that this is intended for aligned data in multiples of four bytes, and / or we should have separate aligned and unaligned versions of the code.

[emaste]

[emaste]

sys/libkern/murmur3_32.c

38

Should we have a different name for this function, due to the multiple-of-4 issue? (I.e., other implementations called murmur3_32 handle the 0-3 byte tail.)

[gnn]

Abandoned in favor of 920.

[emaste]

Adding the 'D' will make a link automatically: D920

[emaste]

The comment should note that this is intended for aligned data in multiples of four bytes, and / or we should have separate aligned and unaligned versions of the code.

I strongly believe we should provide the same api (alignment and size constraints) as other murmur3_32 implementations if we make that the function's name. If we're happy with the alignment and multiple-of-four requirement (I am) we should update the name somehow to reflect that.

[des]

Just add _aligned to the function name and a KASSERT() at the top.

[gnn]

Upated with a name change. Also, leave Jenkins in place for the other
consumer of that hash.

[emaste]

sys/sys/hash.h

127

drop the extra whitespace

[des]

Good to commit.

[gnn]

Done.

New Revision: 272906
URL: https://svnweb.freebsd.org/changeset/base/272906