Page MenuHomeFreeBSD
Differential D46046

tcp cc: re-organize newreno functions into parts that can be re-used
ClosedPublic
Actions

Authored by cc on Jul 19 2024, 8:08 PM.
Tags
None
Referenced Files
F109144858: D46046.id142983.diff
Sat, Feb 1, 9:33 AM
Unknown Object (File)
Fri, Jan 31, 11:56 PM
Unknown Object (File)
Mon, Jan 27, 5:07 PM
Unknown Object (File)
Mon, Jan 27, 5:04 PM
Unknown Object (File)
Mon, Jan 27, 4:40 PM
Unknown Object (File)
Sun, Jan 26, 5:59 PM
Unknown Object (File)
Sun, Jan 26, 5:38 PM
Unknown Object (File)
Fri, Jan 24, 5:53 PM
View All 58 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rscheff
tuexen
Group Reviewers
transport
Commits
rGb6c137de0af1: tcp cc: re-organize newreno functions into parts that can be re-used
Summary

split some of the newreno AIMD functions into smaller parts that can be re-used by other TCP congestion control algorithms

Test Plan

no functional change

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58740
Build 55628: arc lint + arc unit

Event Timeline

cc created this revision.Jul 19 2024, 8:08 PM
Herald added a reviewer: transport. · View Herald TranscriptJul 19 2024, 8:08 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
cc requested review of this revision.Jul 19 2024, 8:08 PM
Harbormaster completed remote builds in B58740: Diff 141161.Jul 19 2024, 8:09 PM
cc edited the summary of this revision. (Show Details)Jul 19 2024, 8:11 PM
cc updated this revision to Diff 141284.Jul 23 2024, 3:37 PM

code clean up

Harbormaster completed remote builds in B58789: Diff 141284.Jul 23 2024, 3:37 PM
cc edited the summary of this revision. (Show Details)Jul 24 2024, 2:03 PM
cc edited the summary of this revision. (Show Details)
cc edited the summary of this revision. (Show Details)Jul 24 2024, 2:07 PM
cc edited the test plan for this revision. (Show Details)Jul 24 2024, 4:23 PM
cc edited reviewers, added: rscheff, tuexen; removed: transport.
cc added a reviewer: transport.
cc edited the summary of this revision. (Show Details)Aug 8 2024, 2:34 PM
cc edited the summary of this revision. (Show Details)
cc edited the test plan for this revision. (Show Details)
cc edited the summary of this revision. (Show Details)Aug 8 2024, 2:36 PM
cc edited the summary of this revision. (Show Details)Aug 8 2024, 5:45 PM
cc edited the summary of this revision. (Show Details)Aug 8 2024, 6:49 PM
cc edited the summary of this revision. (Show Details)Aug 10 2024, 1:55 PM
cc edited the summary of this revision. (Show Details)
cc edited the summary of this revision. (Show Details)Aug 10 2024, 2:14 PM
cc edited the summary of this revision. (Show Details)Aug 10 2024, 2:20 PM
cc edited the summary of this revision. (Show Details)
cc edited the summary of this revision. (Show Details)Aug 11 2024, 8:06 PM
cc edited the summary of this revision. (Show Details)Sep 5 2024, 6:25 PM
cc updated this revision to Diff 142983.Sep 5 2024, 6:34 PM

re-base

Harbormaster completed remote builds in B59319: Diff 142983.Sep 5 2024, 6:34 PM
cc added a child revision: D46546: cc_cubic: use newreno to emulate AIMD in TCP-friendly region.Sep 5 2024, 6:58 PM
cc updated this revision to Diff 142986.Sep 5 2024, 7:05 PM

split this patch into two parts: this patch and D46546

Harbormaster completed remote builds in B59321: Diff 142986.Sep 5 2024, 7:06 PM
cc retitled this revision from cc_cubic: use newreno to emulate AIMD in TCP-friendly region to tcp cc: re-organize newreno functions into parts that can be re-used.Sep 5 2024, 7:10 PM
cc edited the summary of this revision. (Show Details)
cc edited the test plan for this revision. (Show Details)
rscheff accepted this revision.Sep 6 2024, 7:23 AM

lgtm;

This revision is now accepted and ready to land.Sep 6 2024, 7:23 AM
tuexen added inline comments.Sep 16 2024, 8:07 PM
sys/netinet/cc/cc.h
243

Maybe call the function newreno_cc_cwnd_on_multiplicative_decrease()?
This would use the prefix newreno_cc as the functions below and would avoid a confusion with multiple decreases.

245

Use newreno_cc_cwnd as prefix?

cc updated this revision to Diff 143398.Sep 17 2024, 1:46 PM

update function names based on Michael's suggestion

This revision now requires review to proceed.Sep 17 2024, 1:46 PM
Harbormaster completed remote builds in B59509: Diff 143398.Sep 17 2024, 1:46 PM
cc marked 2 inline comments as done.Sep 17 2024, 1:48 PM
tuexen accepted this revision.Sep 17 2024, 1:51 PM
This revision is now accepted and ready to land.Sep 17 2024, 1:51 PM
Closed by commit rGb6c137de0af1: tcp cc: re-organize newreno functions into parts that can be re-used (authored by cc). · Explain WhySep 17 2024, 1:58 PM
This revision was automatically updated to reflect the committed changes.
cc added a commit: rGb6c137de0af1: tcp cc: re-organize newreno functions into parts that can be re-used.

Revision Contents
Changeset List

PathSize
sys/
netinet/
cc/
3 lines
188 lines
20 lines
48 lines

Diff 141161

View Options

sys/netinet/cc/cc.h

Loading...
View Options

sys/netinet/cc/cc.c

Loading...
View Options

sys/netinet/cc/cc_cubic.h

Loading...
View Options

sys/netinet/cc/cc_cubic.c

Loading...